Repository navigation
Pin Node.js and Yarn versions - #46
Merged
Merged
Conversation
Heroku warns that unpinned default versions of Node.js and Yarn can change over time. Pin them via package.json engines and .tool-versions. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Heroku's default (26.13.1) built the app successfully, so pin to it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The runner's preinstalled Node (24.22.3) does not satisfy engines.node 26.x, so yarn install failed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Heroku's build output warns that the default versions of Node.js and Yarn are
not pinned and can change over time:
Node is only used at build time (
esbuildandtailwindcss), but our buildtools are fairly old, so a silent jump across Node majors could break deploys.
Changes
26.xand Yarn to1.22.xviaenginesinpackage.jsonnodejs 26.13.1to.tool-versionsso local dev matchesactions/setup-node@v4step to the CI workflow that readspackage.json, so CI installs the pinned Node versionNotes
heroku/nodejsbuildpack is already in front ofheroku/rubyon the app,so it reads
enginesto pick the versions.the asset build (
esbuildandtailwindcss) succeeded with it.the runner's preinstalled 24.x, which
yarn installrejects againstengines.node: 26.x.Testing
Node 26.x
🤖 Generated with Claude Code