Repository navigation
ci: warm dataset cache directly and decouple Docker smoke test from test suites - #1275
Merged
Merged
Conversation
JulienVig
requested changes
Oct 30, 2026
JulienVig
left a comment
Collaborator
There was a problem hiding this comment.
Good idea to reduce unecessary dependencies! I think we can push this further for the Docker smoke test. However it looks like some dependencies are missing for it in ci-paths.yml .
Looking at the past CI runs it looks like the speedup is pretty unsignificant compared the timing of test/server. It doesn't cost anything to parallelize more but maybe we should focus our efforts on splitting test/server in several parallel jobs?
ale18V
force-pushed
the
ci/decouple-datasets-and-docker
branch
from
November 3, 2026 13:03
1a4e150 to
238d156
Compare
JulienVig
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Currently in
verify.yml:download-datasetsrestoresdatasets/fromactions/cache@v5, and then re-zips and re-uploads the entire folder toactions/upload-artifact@v7on every single CI run so test jobs can pull it withactions/download-artifact.buildwaits ondownload-datasets(needs: [download-datasets, static-analysis]) even though_build.ymlnever downloads or usesdatasets/.build-server-docker(~2m11s) is bundled inside_build.ymlalongsidebuild-topological(~1m06s), forcing all 14 test jobs in_test.ymlto sit idle for an extra ~1 minute waiting for the Docker smoke test even thoughall-buildsis already ready and no test job uses the Docker image.Changes
.github/actions/download-datasets/action.yml&pull-dataset-artifacts/action.yml):lookup-only: trueonactions/cache@v5indownload-datasetsso cache hits complete in seconds without downloading or re-uploading a duplicate workflow artifact.datasets/directly fromactions/cache/restore@v5(withfail-on-cache-miss: true) inpull-dataset-artifacts..github/workflows/verify.yml&_build.yml):download-datasetsfrombuild.needstotest.needs.build-server-dockerout of_build.ymlintoverify.yml(needs: [static-analysis]) so it runs in parallel withbuildandtestinstead of blockingteststartup.