Repository navigation
A plain layout after Free Ports puts every port back on its declared row - #77
Merged
Merged
Conversation
added 2 commits
October 16, 2026 13:47
SidecarProfileInput.sourceExtensions (['.sv', '.v']) reaches the platform's declaration, the watcher's default globs, the openability probe and the raw sidecar commands; new files take the first. sourceExtension stays honoured and is all a Python product needs. Toolkit change T1 of ide/hdl-ide-plan.md.
The Free Ports pass permuted the ports' rows in the session's model, and a later Layout Diagram left them there, since ELK may not move ports and the engine ignores its port geometry: the declared order came back only on a reload. The pass now records a moved port's declared row on the port, and any layout that does not ask for the pass restores every such row before laying out. The test runs Free Ports and then a plain layout on the speculation flow and holds every port at its loaded row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #76. The Free Ports pass permuted the ports' rows in the session's model, and a later Layout Diagram left them there: ELK may not move ports and the engine ignores its port geometry, so the declared order came back only on a reload.
The pass now records a moved port's declared row on the port (
wf:declaredRowY), and any layout that does not ask for the pass restores every such row before laying out. Layout Diagram, Compact Layout, Untangled Layout and a drag therefore lay the ports out as the source declares them, whatever ran before.The test runs Free Ports and then a plain layout on the speculation flow fixture and holds every port at the row the load gave it, with every edge routed. 326 tests pass,
tsc --noEmitis clean.