Repository navigation
Draw images inside patterns and Type3 glyphs on a layer - #85
Merged
Merged
Conversation
A layer took tiling patterns and Type3 fonts from its base. Their content (a pattern's cell, a glyph's procedure) was parsed for the base, so its images carried the base document, and the layer page's image cache refuses an image of another document. CPDF_ImageLoader then read the cache's current entry: null on a page with no cached image yet (the native runtime crashed, WASM drew nothing), else the previous image's (nothing drawn). Chrome prints every rasterized CSS background as a tiling pattern with one image, and every engine open() is a layer. - layer-seam: tiling patterns and Type3 fonts never use the base's entry, as images already didn't. GetCachedType3() drops its base fallback, which can no longer see a base Type3 font. - bug-fix: CPDF_PageImageCache::Accepts() holds the same-document rule, and the image loader loads an image the cache refuses without the cache. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A layer took tiling patterns and Type3 fonts from its base. Their content (a pattern's cell, a glyph's procedure) was parsed for the base, so its images carried the base document, and the layer page's image cache refuses an image of another document. CPDF_ImageLoader then read the cache's current entry: null on a page with no cached image yet (the native runtime crashed, WASM drew nothing), else the previous image's (nothing drawn). Chrome prints every rasterized CSS background as a tiling pattern with one image, and every engine open() is a layer.