Repository navigation
Allow Nx 1.0 - #54
Open
reidmorrison wants to merge 1 commit into
Open
Allow Nx 1.0#54reidmorrison wants to merge 1 commit into
reidmorrison wants to merge 1 commit into
Conversation
Widen the nx requirement from "~> 0.6" to "~> 0.6 or ~> 1.0" so Ortex can be installed next to Nx, EXLA and Bumblebee 1.0. No code changes are needed: the test suite passes unchanged on Nx 1.0.0. The lock stays on Nx 0.6.2 because the dev-only exla and torchx 0.6 dependencies hold it there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widens the Nx requirement to
~> 0.6 or ~> 1.0, so Ortex can be installed next to Nx, EXLA and Bumblebee 1.0.No code changes were needed. I ran the test suite against Nx 1.0.0 and all 117 tests pass (I temporarily dropped
exla/torchxso the lock could move to 1.0.0). CI still runs Nx 0.6.2 frommix.lock, because the dev-onlyexlaandtorchx0.6 keep it there. Happy to add an Nx 1.0 CI job if you'd like.