Skip to content

Fix redundant move in return statement - #22

Merged
jonatanklosko merged 1 commit into
elixir-nx:mainfrom
wrachwal:fix-redundant-move
Nov 5, 2026
Merged

jonatanklosko merged 1 commit into
elixir-nx:mainfrom
wrachwal:fix-redundant-move

Conversation

@wrachwal

@wrachwal wrachwal commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Because ex_struct is a local return value, C++ implicitly moves it when needed. GCC reports the explicit std::move as redundant, and -Werror turns that warning into an error.

@jonatanklosko jonatanklosko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks :)

@jonatanklosko
jonatanklosko merged commit c9484a1 into elixir-nx:main Nov 5, 2026
7 checks passed
@wrachwal
wrachwal deleted the fix-redundant-move branch November 5, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants