Repository navigation
feat: add changelog ref inputs to post-release-verify action - #64
Closed
Svitlana-Dykun wants to merge 5 commits into
Closed
Svitlana-Dykun wants to merge 5 commits into
Svitlana-Dykun wants to merge 5 commits into
Conversation
Add optional core-changelog-ref and pro-changelog-ref inputs to allow callers to specify which git ref to check for changelog entries. This resolves the issue where Pro's changelog only reaches main after a manual cp_main cherry-pick, which can happen after the release. Defaults to 'main' to maintain backward compatibility. Ref: https://github.com/elementor/elementor-pro/pull/7792#discussion_r4345754281 Co-authored-by: Svitlana-Dykun <Svitlana-Dykun@users.noreply.github.com>
Add core_changelog_ref and pro_changelog_ref inputs to the reusable post-release-check.yml workflow and pass them through to the post-release-verify action. This allows elementor-pro to specify which git ref to check for the changelog when calling the workflow. Both inputs default to 'main' for backward compatibility. Co-authored-by: Svitlana-Dykun <Svitlana-Dykun@users.noreply.github.com>
Empty changelog refs use the version being verified, so a stable release passes before the changelog sync to main. Co-authored-by: Cursor <cursoragent@cursor.com>
The post-release workflow already passes the version tag. Co-authored-by: Cursor <cursoragent@cursor.com>
Svitlana-Dykun
marked this pull request as ready for review
October 22, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
post-release-verifyaction's "Changelog on main (Pro/Core)" check currently reads changelog entries from themainbranch. For Elementor Pro, the changelog only reachesmainafter a manualcp_maincherry-pick, which typically lands after the release is published. This causes the verify job to fail and downstream jobs (like "Upgrade site smoke") to be skipped.Example: Pro 4.3.2 (PR #7792) failed verification because the changelog was not yet on
mainat release time.Solution
Added optional inputs to both the
post-release-verifyaction and the reusablepost-release-check.ymlworkflow:core-changelog-ref/core_changelog_ref: Git ref to check for Core changelog (defaults tomain)pro-changelog-ref/pro_changelog_ref: Git ref to check for Pro changelog (defaults tomain)Both inputs default to
mainto maintain backward compatibility - existing callers continue working exactly as before.Usage for elementor-pro
In
elementor-pro's.github/workflows/post-release-check.yml, add thepro_changelog_refinput when calling this reusable workflow:This tells the action to check the release tag (e.g.,
4.3.2) for the changelog instead ofmain, avoiding the cp_main timing issue.Note: Use
inputs.pro_version(the release tag like4.3.2), not a custom variable. If elementor-pro's workflow dispatch uses a different input name likeversion, adjust accordingly.Changes
Action (
actions/post-release-verify/action.yml)core-changelog-refandpro-changelog-refinputs withmaindefaultscheckMainChangelogfunction to accept and use arefparameterReusable Workflow (
.github/workflows/post-release-check.yml)core_changelog_refandpro_changelog_refinputs to bothworkflow_dispatchandworkflow_callpost-release-verifyactionmainfor backward compatibilityBuild Artifacts
actions/post-release-verify/dist/index.jswith the changesVerification
npm run build)npm run lint- eslint, tsc, prettier)main)