Repository navigation
fix: accept --include descriptions in send-report as its help text says - #2401
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
Contributor
|
👋 @RaphaelFakhri |
RaphaelFakhri
requested a deployment
to
elementary_test_env
October 21, 2026 09:13 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
--includehelp text ofedr send-reportsays "Currently only --include descriptions is supported", but the CLI only setsinclude_descriptionwhen the value is exactlydescription. Running the command as documented sends the Slack summary without test descriptions, and nothing reports that the value was ignored.Fix
send-reportnow enables descriptions for bothdescriptions(the documented value) anddescription(the value the code accepted so far), so existing commands keep working.Tests
New
tests/unit/cli/test_send_report_include.pyinvokessend-reportthroughCliRunnerwithDataMonitoringReportmocked and checks theinclude_descriptionargument for no--include,descriptions,descriptionand an unknown value.descriptionscase fails (1 failed, 3 passed).pre-commit runon the changed files passes (black, isort, flake8, mypy, typos).Fixes #2400
Summary by CodeRabbit
Bug Fixes
send-reportcommand now recognizes bothdescriptionanddescriptionswhen including report descriptions.Tests
--includevalues.