Skip to content

fix(cli): declare PyYAML as a dependency - #2397

Open
dobsontom wants to merge 1 commit into
elementary-data:masterfrom
dobsontom:declare-pyyaml
Open

dobsontom wants to merge 1 commit into
elementary-data:masterfrom
dobsontom:declare-pyyaml

Conversation

@dobsontom

@dobsontom dobsontom commented Oct 19, 2026 •

Copy link
Copy Markdown

This PR adds PyYAML to the CLI's dependencies. command_line_dbt_runner.py imports it, and it used to arrive with dbt-core, so edr has failed on startup without it since 0.26.1 made dbt-core optional. The >=6.0 floor is what dbt-core required.

Closes #2398

Summary by CodeRabbit

  • Chores
    • Updated an underlying application requirement. There are no changes to visible features or user-facing behavior in this release.

@github-actions

Copy link
Copy Markdown
Contributor

👋 @dobsontom
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@dobsontom
dobsontom requested a deployment to elementary_test_env October 19, 2026 20:49 — with GitHub Actions Waiting
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 13a0589e-d89e-4656-99ae-2e6ec7508d5a
📥 Commits

Reviewing files that changed from the base of the PR and between 9c13ec1 and 2ddb5dc.

📒 Files selected for processing: 1
  • pyproject.toml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The required dependencies now include PyYAML, with a minimum version of 6.0.

Changes: PyYAML dependency

Layer / File(s) Summary
Declare PyYAML dependency
pyproject.toml
The required dependencies include PyYAML version 6.0 or later.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: haritamar

Merge Risk: ⚪ Minimal · up to 2ddb5

The CLI’s documented installation paths install the project with PyYAML included as a required dependency. No actionable merge-blocking risk was identified.

### Architecture Summary

Architecture risk: 🔵 Low · up to 2ddb5

The change affects 1 system.

Changed systems: pyproject.toml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — pyproject.toml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in pyproject.toml: Added pyyaml to the required dependencies, constrained to version 6.0 or later.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly states the change: adding PyYAML as a dependency. This matches the PR’s main objective.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch is waiting to be deployed

1 waiting deployment
elementary_test_env — 2ddb5dc0 Waiting Oct 19, 2026 by dobsontom via approve-fork #2721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

edr fails to start without PyYAML, which it imports but doesn't declare

1 participant