Repository navigation
Conversation
Prefer packagerConfig.appVersion over packageJSON.version when naming the DMG artifact, matching Packager's fallback for an absent or empty version. Keep explicit maker names unchanged. Add regression coverage for version overrides, fallback and custom names. This change is limited to maker-dmg. Fixes electron#3523 Assisted-By: Hermes Agent
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance disclosure: Hermes Agent assisted with the code, tests, and this description. The operator authorized this draft submission; it remains pending human code review and macOS packaging validation.
Summarize your changes:
Addresses the DMG case in #3523.
Use
forgeConfig.packagerConfig.appVersion || packageJSON.versionin the default DMG artifact name, matching Packager's fallback for an absent or emptyappVersion. An explicitMakerDMGname still takes precedence; the architecture-specific output directory and installer options are unchanged. Other makers are outside this PR's scope.Verification
yarn test:fast packages/maker: 14 files / 138 tests passed, independently rerun after review.yarn build, scopedoxfmt --check,oxlint, andgit diff --checkpassed.yarn test:fast: 715 passed, 2 failed, 6 todo. Both failures are Vite configuration tests expecting fixed ports (5173/5183) that were occupied locally; the same failures were reproduced with the unmodified production source. The full-suite checkbox is therefore left unchecked.Tested on Windows with Node 24.19.0 and Yarn 4.18.0 against main at
16d47dc2. No real DMG was created or mounted on macOS, including no real MAS/architecture packaging matrix; this is why the PR is a draft. The branch merges cleanly withfdb682ce.