Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying the README configuration or the output of
--dump-config-defaultssetsmirrorto the literal stringNone, causing downloads to target an invalid host.Omit options without defaults from the dump and README example, use plain INI values, and explain how an omitted mirror selects the built-in download source. Two round-trip tests load the generated configuration and the actual README block and compare every resulting option with its default.
Validation: both round-trip tests failed before the fix and pass afterward; full non-integration suite: 389 passed, 10 skipped, 5 deselected, 2 existing fish xfails. Flake8 and
git diff --checkpassed.Closes #422.