Repository navigation
Space compound assignment operators by default in blink BinaryOperatorSpaces - #239
Merged
Merged
Conversation
…rSpaces Compound assignment operators (.=, +=, -=, *=, etc.) are always binary and never unary, so PHP-CS-Fixer's BinaryOperatorSpaces spaces them under the default mode like plain =. blink treated them as extra operators that only got spaced when explicitly listed in the operators option, so code like $x .='c' kept its missing space and diverged from ECS. Move the compound assignment family into the default target set; arithmetic operators that can be unary stay guarded. Resolves the .= laravel parity divergences (ServeFileTest, BladeCompiler).
TomasVotruba
force-pushed
the
blink-compound-assignment-spacing
branch
from
October 30, 2026 16:39
604de7c to
2ba6d3e
Compare
TomasVotruba
enabled auto-merge (squash)
October 30, 2026 16:39
TomasVotruba
disabled auto-merge
October 30, 2026 16:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compound assignment operators (
.=,+=,-=,*=, ...) are always binary and never unary, so PHP-CS-Fixer'sBinaryOperatorSpacesFixerspaces them under the default mode, like plain=.blink treated them as extra operators that only got spaced when explicitly listed in the
operatorsoption. So code like$x .='c'kept its missing space and diverged from PHP ECS.This moves the compound assignment family into the default target set; arithmetic operators that can be unary (
+,-,*,&,|) stay guarded as before. Verified against the real laravel files; added default-spacing regression cases.