Repository navigation
Make blink StandaloneLinePromotedProperty a file-level fixer - #238
Merged
Merged
Conversation
Symplify's StandaloneLinePromotedPropertyFixer is a file-level candidate: once any constructor in the file declares a promoted property, it breaks the params of every constructor in the file onto standalone lines, plain ones included. blink gated the split per-constructor (only promoted ones), so plain constructors next to a promoted one stayed inline and diverged from ECS. Gate on the file instead, then reflow every __construct. Resolves 10 of the 37 laravel parity divergences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symplify's
StandaloneLinePromotedPropertyFixeris a file-level candidate: once any constructor in the file declares a promoted property, it breaks the params of every constructor in the file onto standalone lines - plain ones included.blink gated the split per-constructor (only the promoted one), so a plain constructor sitting next to a promoted one stayed inline and diverged from PHP ECS. This changes the rule to check the file for a promoted constructor first, then reflow every
__construct.Resolves 10 of the 37 laravel parity divergences (1.20% -> ~0.87%). Verified locally against the real laravel files with the 5-set parity config. Added a file-level-trigger regression test.