Skip to content

fix(security): pin jackson-core to 2.23.0 (CVE-2026-68498) - #1099

Open
vinokurig wants to merge 1 commit into
mainfrom
CRW-13952
Open

vinokurig wants to merge 1 commit into
mainfrom
CRW-13952

Conversation

@vinokurig

@vinokurig vinokurig commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

jackson-core resolved to 2.15.0 in the server WAR, by way of com.auth0:jwks-rsa. That line never got a fix for the delayed maxNameLength enforcement on char-backed input, so pin it to 2.23.0, which is past the 2.22.2 fix.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Summary by CodeRabbit

  • Chores
    • Updated project configuration to centralize version management for a shared software component.
    • This change affects project setup rather than the app’s visible features or behavior. No new user-facing capabilities or interface changes are included in this update.

jackson-core resolved to 2.15.0 in the server WAR, by way of
com.auth0:jwks-rsa. That line never got a fix for the delayed
maxNameLength enforcement on char-backed input, so pin it to 2.23.0,
which is past the 2.22.2 fix.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The root POM adds a Jackson version property set to 2.23.0 and uses it to manage the version of jackson-core.

Changes: Jackson Core Dependency Management

Layer / File(s) Summary
Define and manage Jackson Core version
pom.xml
The POM adds the com.fasterxml.jackson.version property set to 2.23.0 and uses it as the managed version for com.fasterxml.jackson.core:jackson-core.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: Minimal · up to 872d7

This change pins the Jackson 2.x core library to a newer version in the root build file so the server WAR picks up the upstream fix. No concrete failure has been identified. It would still be worth running a build and a JWKS lookup test to confirm the newer core works with the older databind that jwks-rsa pulls in.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: pinning jackson-core to 2.23.0 to fix CVE-2026-68498. The raw summary confirms the root pom.xml adds a jackson version property at 2.23.0 and manages jackson-core with…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: pinning jackson-core to 2.23.0 to fix CVE-2026-68498. The raw summary confirms the root pom.xml adds a jackson version property at 2.23.0 and manages jackson-core with it. The title is specific, short, and matches the changeset. It uses a conventional 'fix(security):' prefix, which is acceptable.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

OSV Scanner (2.7.0)

pom.xml

OSV Scanner exited with code 128 without a usable report

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 385b4d0f-86a2-47ae-a4bc-983b344700fd
Commits

Reviewing files that changed from the base of the PR and between d40c44b and 872d7c9.

Files selected for processing: 1

  • pom.xml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@github-actions

Copy link
Copy Markdown

Docker image build succeeded: quay.io/eclipse/che-server:pr-1099

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/cheServer/deployment", "value": {containers: [{image: "quay.io/eclipse/che-server:pr-1099", name: che}]}}]"

@openshift-ci

openshift-ci Bot commented Nov 18, 2026

Copy link
Copy Markdown

@vinokurig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v22-bitbucket-gitea-all-tests 872d7c9 link true /test v22-bitbucket-gitea-all-tests
ci/prow/v22-gitlab-with-oauth-setup-flow 872d7c9 link true /test v22-gitlab-with-oauth-setup-flow
ci/prow/v22-gitlab-all-tests 872d7c9 link true /test v22-gitlab-all-tests
ci/prow/v22-azure-all-tests 872d7c9 link true /test v22-azure-all-tests
ci/prow/v22-che-smoke-test 872d7c9 link true /test v22-che-smoke-test
ci/prow/v22-github-all-tests 872d7c9 link true /test v22-github-all-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci

openshift-ci Bot commented Nov 18, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: svor, vinokurig

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants