Repository navigation
Conversation
Port the ConnectionPool change from ce37cd8 to the existing borrow listener API.
foc-nico
marked this pull request as ready for review
November 20, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
onAfterBorrowConnection()runs after the pool checks out a connection but beforegetConnection()hands it to the caller. If the listener throws, the caller never receives the connection and cannot close it. The connection stays checked out, so repeated listener failures can exhaust the pool and block otherwise healthy requests.This change closes the borrowed connection on the failure path and rethrows the original error. If cleanup also fails, that failure is attached as a suppressed exception. The successful borrow path and the public API are unchanged.