Repository navigation
Fix lint-format failures on develop - #340
Open
markbujehein wants to merge 1 commit into
Open
markbujehein wants to merge 1 commit into
markbujehein wants to merge 1 commit into
Conversation
develop fails lint-format, so every branch made from it does too: - ruff format: test_easy_list.py and test_new_base.py from #323 and #325 were merged unformatted. - prettier: pixi.toml, prettierrc.toml and pyproject.toml are unchanged since the last green run (77d7967), but CI installs prettier and prettier-plugin-toml unpinned, so newer formatting rules now flag them. Also applies "pixi run fix" docstring formatting to sampler.py and minimizer_bumps.py, and the pixi.lock platform renaming from the current pixi version, as done on other branches.
markbujehein
added
[scope] maintenance
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #340 +/- ##
========================================
Coverage 83.24% 83.24%
========================================
Files 63 63
Lines 5324 5324
========================================
Hits 4432 4432
Misses 892 892
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
|
This can't be merged yet. It misses the new keyword for aligning comments. We should make a new release of the templates, and then make a copier-update PR. That should fix the failing CI everywhere. Just waiting on @AndrewSazonov to look at my PR in templates and then make a release of it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
developfails the lint-format workflow, so every branch made from it does too (e.g. #339). This has been a recurring issue for me (!), so I've had @claude track down what is going on:test_easy_list.pyandtest_new_base.pyfrom Fix EasyList serialization issue and add test #323 and Fix issue 324 and add tests #325 were merged unformatted.pixi.toml,prettierrc.tomlandpyproject.tomlare unchanged since the last green run (77d7967), but CI installsprettierandprettier-plugin-tomlunpinned, so newer formatting rules now flag them.Note, some of these can seemingly can pass
pixi run fix/pixi run check, which is strange, but are caught by the Github workflow!Also includes the
pixi run fixdocstring formatting ofsampler.pyandminimizer_bumps.py, and thepixi.lockplatform renaming from the current pixi version (the lock file was also recently updated to the new format in diffraction-lib).Upstream
copier updatewill probably reset the TOML files, so that part should also be fixed in templates; AFAIK, it's caused by the workflow and the prettier TOML not being synced up (do you know anything about this @AndrewSazonov?)