Repository navigation
fix: Reject unsigned integer overflow before conversion - #20
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
An unsigned value can wrap into a valid negative integer before
marshalIntegerchecks its range. For example,Marshal(NewItem(^uint64(0)))currently succeeds with"-1".Check the unsigned value against the structured field integer limit before converting it to
int64. Values outside that range now returnErrNumberOutOfRange.The regression tests cover unsigned widths, valid boundary values, overflow boundaries, and nested items. They also check that an error returns an empty string.
Verified with
go test -race -covermode atomic -coverprofile=profile.covon Go 1.27.2 and 1.26.9, with 95.3% coverage.golangci-lint runpasses with zero issues using v2.14.0.