Repository navigation
Replace pytz with zoneinfo - #717
Closed
davetapley wants to merge 1 commit into
Closed
davetapley wants to merge 1 commit into
davetapley wants to merge 1 commit into
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surprisingly few changes.
Only caveat is that if the system doesn't have IANA timezone data, fetching a
TIMESTAMP WITH TIME ZONEas adatetimecould raiseZoneInfoNotFoundError.Fix would be:
tzdataUntested assumption: I presume since anyone using this functionality would already have
pytzexplicitly installed anyway (see duckdb/duckdb#11974), it shouldn't be an issue.#406