Skip to content

Fix unexpected service scaling upon submission #4433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvstme merged 1 commit into from
Oct 29, 2026
Merged

Fix unexpected service scaling upon submission #4433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/dstack/_internal/server/background/pipeline_tasks/runs/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
from sqlalchemy.ext.asyncio import AsyncSession

from dstack._internal.core.models.configurations import (
DEFAULT_REPLICA_GROUP_NAME,
ServiceConfiguration,
)
from dstack._internal.core.models.runs import JobStatus, JobTerminationReason, RunSpec
Expand All @@ -33,15 +32,6 @@ def compute_desired_replica_counts(
prev_counts: PerGroupDesiredCounts = (
json.loads(run_model.desired_replica_counts) if run_model.desired_replica_counts else {}
)
if (
prev_counts == {}
and len(replica_groups) == 1
and replica_groups[0].name == DEFAULT_REPLICA_GROUP_NAME
):
# Special case to avoid dropping the replica count to group.replicas.min
# when a 0.20.7+ server first processes a service created by a pre-0.20.7 server.
# TODO: remove once most users upgrade to 0.20.7+.
prev_counts = {DEFAULT_REPLICA_GROUP_NAME: run_model.desired_replica_count}
desired_counts: PerGroupDesiredCounts = {}
total = 0
for group in replica_groups:
Expand Down
Loading