Repository navigation
ci: sync the Antigravity PR reviewer with the current template - #336
Conversation
Re-installs antigravity-pr-review (template b8501ed) over a copy that was an unmodified older template version, so nothing repo-specific is lost. The headline fix: the UTF-8 scrub after byte caps was a no-op on glibc, because GNU `iconv -c` exits 1 whenever it drops bytes and the old code discarded its output, so agy could be handed a split UTF-8 sequence. It now falls back to python3 and is shared by the prompt and review-output paths. Also: the shallow merge-base fetches carry the token header, the README (installed as .github/AGY-REVIEWER.md) lists the real file set, and every template fix since this copy was installed comes along. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 45731643-434c-47ff-b949-3c944b6505f6) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7a30d169a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (line[i] ~ /^<details>/) opens++ | ||
| if (line[i] == "</details>") closes++ | ||
| } | ||
| if (closes > opens) n-- |
There was a problem hiding this comment.
Restrict wrapper removal to legacy archive layouts
If an archived review contains a valid <details open> block, this counter ignores its opening tag but counts its </details>. Consequently, agy_body_archive removes the round's own closing tag even from a correctly formatted, newly generated archive. This reproduces with one round containing one nested <details open> block and leaves the comment's collapsible sections unbalanced on the next review. Detect the legacy wrapper explicitly rather than inferring its presence from incomplete HTML tag counts.
Useful? React with 👍 / 👎.
| for t in python3 mv rm; do ln -sf "$(command -v "$t")" "$TMPD/noiconv/$t"; done | ||
| printf 'abc\xe2\x82' > "$TMPD/split" | ||
| ( PATH="$TMPD/noiconv"; agy_scrub_utf8 "$TMPD/split" ) |
There was a problem hiding this comment.
Preserve interpreter dependencies in the no-iconv test
When python3 resolves to a pyenv shim, symlinking it into this directory and replacing PATH with only that directory prevents the shim's #!/usr/bin/env bash interpreter from being found. The fallback therefore never runs, and the self-test reports a UTF-8 regression despite the production helper working correctly. This is reproducible in the provided environment: bash scripts/agy-review-selftest.sh fails only this assertion. Resolve the actual Python interpreter or retain the executables required by the shim while hiding iconv.
Useful? React with 👍 / 👎.
The workflow comment no longer calls the outside-contributor approval setting "belt-and-suspenders": for a pull_request event a fork controls the workflow file, so that setting is the gate. The self-test now fails if the workflow ever has more than one timeout-minutes, which would make its budget check read the wrong value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: e3f5b5c4-b682-4103-b8ea-36126f826f76) |
The reviewer is already on this repository's default branch, so the three bootstrap steps (a PR-head checkout and install that only fire while the default branch has no reviewer) can never run here. Keeping them leaves a PR-head checkout path in the workflow, which CodeQL flags as actions/untrusted-checkout (high). The comment and the AGY-REVIEWER.md note match RustyNES, VeridianOS and switch2-hub-patcher. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 2cd7062e-50b9-4527-878c-65398e2bfd5b) |
Antigravity review (Gemini via Ultra)Synchronizes the repository's Antigravity PR review workflow, scripts, self-test suite, and documentation ( Blocking issuesNone found. Suggestions
Nitpicks
Automated first-pass review by Earlier review rounds (newest first)Round reviewed at 2026-11-14 12:59 UTCAntigravity review (Gemini via Ultra)Synchronizes the repository's Antigravity PR review workflow, scripts, self-tests, and documentation with the upstream reviewer template, adding API-based write-permission checks, diff-size timeout scaling, archive wrapper migration, and UTF-8 truncation scrubbing. Blocking issuesNone found. Suggestions
Nitpicks
Automated first-pass review by |
From the Antigravity reviews of these template-sync PRs; each fix has a self-test check that failed before it: - agy_body_archive no longer drops a clean round's closing </details> when the round quotes a standalone </details> or uses <details open>. - agy_cap_prompt checks the size first, so a prompt that already fits is not cut and the model is not told its diff was truncated. - agy_cut_file refuses a non-positive size rather than handing GNU `head -c -N` a negative count. - The self-test budget uses a pinned AGY_PRINT_TIMEOUT when one is set. - MAX_PROMPT_BYTES defaults to 120000 (its ceiling), ending the spurious clamp warning on every run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: daedce5a-02d4-4c81-9f03-b5bbb803cd3e) |
What and why
This PR re-installs the Antigravity PR reviewer from the current antigravity-pr-review template (
b8501ed). The copy it replaces was an unmodified older template version: every overwritten file matched a template commit byte for byte. So nothing specific to this repo is lost, and the existing style guide (.github/agy-review.md) is kept.Fixes it brings:
iconv -cexits 1 whenever it drops bytes. That's exactly what happens after a byte cut, and the old code threwiconv's output away on failure, so the cleanup did nothing and agy could be handed a split UTF-8 sequence. It now falls back topython3, and one helper serves both the prompt and the review-output paths. The self-test covers it, including withiconvhidden..github/AGY-REVIEWER.md(the template README) is added or updated, and its file table now matches what the installer copies.Testing
bash scripts/agy-review-selftest.shpasses on this branch.actionlint .github/workflows/antigravity-review.ymlis clean.🤖 Generated with Claude Code
Note
Medium Risk
Changes who can trigger reviews and how self-hosted runner jobs fetch diffs and post comments; mistakes could block reviews or weaken gates, but scope is CI tooling only.
Overview
Reinstalls the Antigravity PR reviewer from the upstream template: new
.github/AGY-REVIEWER.md, refreshed workflow, and updatedscripts/*(existing.github/agy-review.mdis unchanged).Workflow trims permissions (
issues: writeremoved), raises job timeout to 45m, and pins diff-scaled timeouts (900 s/MiB, 900 s per-attempt cap, 2 retries, 300 s lock wait). Security comments now stress fork approval and thatagy_has_write_accessis the real/agy-reviewgate.Reviewer behavior hardens failure modes: any line-1
Error:/ truncated tool notice and[agy] print timeoutno longer post as reviews; shared truncation +agy_scrub_utf8(iconv with python3 fallback) on prompt and output; timeouts scale with diff size; large-diff fallback usesGIT_CONFIG_*auth,agy_fetchon all fetches, and safer merge-base handling;agy_has_write_accessreplacesauthor_associationfor comment triggers.Comment archives fix nested
<details>viaAGY_ARCHIVE_SECTION,agy_assemble_archive, reviewed-at timestamps, paginated comment merge (jq -s add), and visible API/jq errors instead of silent fallbacks.Self-test grows into broad regression coverage for the above;
_agy_print.shadds usage checks and safer prompt reads.Reviewed by Cursor Bugbot for commit 80a85bc. Bugbot is set up for automated code reviews on this repo. Configure here.