Repository navigation
fix(ci): run the prune scripts with bash; their executable bit never reached git - #667
Conversation
…reached git
The preview-env-cleanup workflow's first real run on main, run
43830700505, triggered by v3.7.1's branch deletion, failed both jobs
with exit 126 ("permission denied") before either script did anything.
Both prune scripts are recorded as 100644. They were written and
committed in worktrees with core.fileMode=false, which is the
workspace's rule for trees touched from the NAS mirror, so the local
chmod +x was never staged. The stub-gh tests ran the scripts from the
working tree, where they were executable, so they could not see it.
Two fixes, either sufficient alone:
- The workflow invokes `bash scripts/ci/<script>`, so the mode no longer
matters, with a comment saying why.
- The index records 100755 for both, via update-index --chmod=+x, which
works with fileMode off.
Audited the rest of the workflows for the same failure. Every other
script a workflow runs directly is 100755; scripts/render_privacy.py is
100644 but is run as `python3 scripts/...`.
CHANGELOG [Unreleased] records the fix.
Gates: actionlint clean; markdownlint passed; release_anchor_audit 18/0.
The fix itself is proven only by the workflow's next run on main, which
this PR's merge triggers (its branch deletion).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 0ea2fb39-1677-4320-8d37-5e449b6ff821) |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Antigravity review (Gemini via Ultra)This trivial fix invokes the two preview-cleanup scripts explicitly via Blocking issuesNone found. Suggestions
NitpicksNone. Automated first-pass review by |
The preview cleanup never ran: exit 126
The
Preview environment cleanupworkflow's first real run onmain(run 43830700505, triggered by v3.7.1's branch deletion) failed both jobs with exit 126, permission denied, before either script did anything.Both
scripts/ci/prune-*.share recorded as100644. They were committed from worktrees withcore.fileMode=false(the workspace's NAS rule), so the localchmod +xwas never staged. My stub-gh tests ran them from the working tree, where they were executable, so they could not catch this.Fix
bash scripts/ci/<script>, so the mode no longer matters.100755for both scripts.I checked every other workflow for the same failure: every other script run directly is
100755, andrender_privacy.pyis run aspython3 ....Verification
actionlintand markdownlint are clean, and the anchor audit passes. The real proof is the workflow's next run onmain, which this PR's own branch deletion triggers.🤖 Generated with Claude Code
Note
Low Risk
CI-only invocation change for cleanup scripts; no application or auth logic touched.
Overview
Preview environment cleanup failed on its first
mainrun (v3.7.1) with exit 126 becauseprune-deployments.shandprune-preview-environments.shwere checked in without the executable bit (core.fileMode=falsein the commit trees).Both jobs in
.github/workflows/preview-env-cleanup.ymlnow invoke the scripts asbash scripts/ci/...instead of running them directly, with comments documenting the NAS/fileMode constraint. The changelog Unreleased section records the fix; the scripts’ executable bit is also set in git so local runs stay consistent.Reviewed by Cursor Bugbot for commit fc312e3. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit