Repository navigation
ci(review): wait out another repository's review for the agy lock - #665
Conversation
The agy lock (~/.gemini/antigravity-cli/.agy-review.lock) serialises EVERY repository's review on the host, because agy is one singleton language server per user. AGY_LOCK_WAIT was 300 s, shorter than one review elsewhere. Observed 2026-11-15: RustyNES_MiSTer PR #79 and RustyNES PR #664 opened together, #664's review of a large diff took the lock, and #79's job gave up ("agy lock timed out after 300s", run 43685337620) and went red without reviewing anything. Any two PRs opened at once in two repositories on the same runner host can hit it, from either side. AGY_LOCK_WAIT 300 -> 1800 s, which outlasts another review's two attempts at a 15-minute cap; timeout-minutes 45 -> 80 so the worst case still fits: 1800 + 2 x 900 + 15 = 3615 s ("worst case 3615s 80m (job timeout) fits with 2 minutes to spare" from scripts/agy-review-selftest.sh; all checks passed; actionlint clean). The runner is self-hosted, so the longer wait bills nothing, and the lock still fails closed: a timeout exits rather than running agy unserialised. The same change landed on RustyNES_MiSTer #79 (fa3dbbb), where both reviews after it ran green; this applies it here, at the maintainer's request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014qfTKi2M3swo7qnwvYCkDj
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 2c534f3b-c856-48c8-b36e-2d567600545f) |
Antigravity review (Gemini via Ultra)Raises Blocking issuesNone found. Suggestions
Nitpicks
Automated first-pass review by Earlier review rounds (newest first)Round reviewed at 2026-11-15 16:47 UTCAntigravity review (Gemini via Ultra)Increases Blocking issuesNone found. Suggestions
NitpicksNone. This is a trivial configuration update and the worst-case timeout arithmetic ( Automated first-pass review by Round reviewed at 2026-11-15 07:19 UTCAntigravity review (Gemini via Ultra)Increases Blocking issuesNone found. Suggestions
Nitpicks
Automated first-pass review by |
Antigravity on RustyNES #665: the comment said 1800 s "outlasts another review's two attempts at a 15-minute cap", but agy-review.sh holds the flock across the whole retry loop, the 15 s pause between attempts included, so another review can hold it for 2 x 900 + 15 = 1815 s plus process start-up. AGY_LOCK_WAIT 1800 -> 1860; the comment now gives the real arithmetic. Worst case 1860 + 2 x 900 + 15 = 3675 s, inside the 80-minute job timeout ("worst case 3675s 80m (job timeout) fits with 2 minutes to spare"; selftest: all checks passed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014qfTKi2M3swo7qnwvYCkDj
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 7428ecc1-a2ab-43bf-bb26-f7ed3fab99f6) |
…lure Antigravity on #665 (no blocking issues): the configuration table and the troubleshooting section did not mention AGY_LOCK_WAIT, so a repository using the template had no way to learn that the lock is shared by every repository's review on the host, how the wait interacts with timeout-minutes, or what the red "agy lock timed out after Ns" job means. Added a table row (default 600, workflow 1860; why 1860 outlasts one review's whole hold; that raising it means raising timeout-minutes, which the selftest checks) and a troubleshooting entry (cause, re-run, how to size the wait, fail-closed). Its other suggestion, that 1860 s can still be exceeded when three or more repositories queue large diffs at once, is left as is: the reviewer itself says no change is needed unless that becomes common, and a longer wait would only lengthen every job's worst case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014qfTKi2M3swo7qnwvYCkDj
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: cb236c1e-c693-4d02-b52e-69682a551d4f) |
Antigravity rounds: answered
🤖 Generated with Claude Code |
The Antigravity reviewer waited 300 s for the
agylock. That lock is shared by every repository's review on the host, so a review elsewhere could make this one time out and go red with no review. That happened to RustyNES_MiSTer #79 when it opened together with #664.AGY_LOCK_WAIT: 300 to 1800 s.timeout-minutes: 45 to 80.The worst case is 1800 + 2 × 900 + 15 = 3615 s, checked by
scripts/agy-review-selftest.sh(all checks passed).actionlintis clean.The runner is self-hosted, so the longer wait bills nothing. The lock still fails closed.
This is the same change as RustyNES_MiSTer #79 (
fa3dbbb), where both later reviews ran green. The reviewer template got it too.🤖 Generated with Claude Code
Note
Low Risk
CI-only timing and documentation; no changes to review logic or security gates beyond longer worst-case job duration.
Overview
Raises
AGY_LOCK_WAITfrom 300s to 1860s and the review job’stimeout-minutesfrom 45 to 80 so one repository’s review can wait out a full hold of the host-wide sharedagylock (another repo’s two 900s attempts plus backoff).Documents
AGY_LOCK_WAITin.github/AGY-REVIEWER.mdand adds troubleshooting for "agy lock timed out" (red job, no comment) when concurrent PRs on the same runner queue across repositories.Reviewed by Cursor Bugbot for commit 59005c3. Bugbot is set up for automated code reviews on this repo. Configure here.