Repository navigation
ci: sync the Antigravity PR reviewer with the current template - #262
Conversation
Re-installs antigravity-pr-review (template b8501ed) over a copy that was an unmodified older template version, so nothing repo-specific is lost. The headline fix: the UTF-8 scrub after byte caps was a no-op on glibc, because GNU `iconv -c` exits 1 whenever it drops bytes and the old code discarded its output, so agy could be handed a split UTF-8 sequence. It now falls back to python3 and is shared by the prompt and review-output paths. Also: the shallow merge-base fetches carry the token header, the README (installed as .github/AGY-REVIEWER.md) lists the real file set, and every template fix since this copy was installed comes along. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 0f0ac44f-919d-44f7-a282-34ebfb229775) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb9e316dc8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Cap prompt file $1 at $2 bytes, keeping room for a notice written after the cut. | ||
| agy_cap_prompt() { | ||
| local notice=$'\n\n--- NOTE: TRUNCATED PROMPT ---\nThe prompt, including the diff, was cut at the argument-size limit; you have NOT seen\nthe rest. Say at the top of your review that it covers a truncated diff, and do not state or\nimply that the whole change was reviewed.\n' | ||
| agy_cut_file "$1" "$(( $2 - ${#notice} ))" || return 1 |
There was a problem hiding this comment.
Check the full prompt budget before reserving notice space
When AGY_DIFF_MODE=inline produces a prompt just below MAX_PROMPT_BYTES, this helper unnecessarily truncates the diff because it compares the file size against the budget minus the notice length rather than against the full budget first. For example, a 119,923-byte prompt with a 120,000-byte budget loses its final changes and becomes a 120,000-byte truncated prompt, even though the original fits. Check whether the prompt exceeds the full budget before cutting it to reserve space for the notice.
Useful? React with 👍 / 👎.
The workflow comment no longer calls the outside-contributor approval setting "belt-and-suspenders": for a pull_request event a fork controls the workflow file, so that setting is the gate. The self-test now fails if the workflow ever has more than one timeout-minutes, which would make its budget check read the wrong value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 9ac38f91-5c4d-49ae-a4b9-8c9edadb025b) |
The reviewer is already on this repository's default branch, so the three bootstrap steps (a PR-head checkout and install that only fire while the default branch has no reviewer) can never run here. Keeping them leaves a PR-head checkout path in the workflow, which CodeQL flags as actions/untrusted-checkout (high). The comment and the AGY-REVIEWER.md note match RustyNES, VeridianOS and switch2-hub-patcher. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 95b8265e-c034-41ad-9136-38d79f0e67c2) |
Antigravity review (Gemini via Ultra)This PR syncs the Antigravity PR reviewer workflow, scripts, self-test suite, and documentation with the upstream template, adding write-permission verification for Blocking issuesNone found. Suggestions
Nitpicks
Automated first-pass review by Earlier review rounds (newest first)Round reviewed at 2026-11-14 13:37 UTCAntigravity review (Gemini via Ultra)This PR updates the Antigravity PR reviewer workflow, scripts, self-test suite, and documentation to enforce collaborator write-access checks via the GitHub API, scale print timeouts by diff size, isolate archive wrapper sentinels, avoid exposing tokens in Blocking issuesNone found. Suggestions
Nitpicks
Automated first-pass review by Earlier review rounds (newest first)Round reviewed at 2026-11-14 12:33 UTCAntigravity review (Gemini via Ultra)Synchronizes the repository's Antigravity PR reviewer workflow, helper scripts, self-test suite, and documentation with the current upstream template (adding collaborator write-access verification, diff-size timeout scaling, archive section sentinels, and UTF-8/truncation helpers). Blocking issuesNone found. Suggestions
Nitpicks
Automated first-pass review by |
From the Antigravity reviews of these template-sync PRs; each fix has a self-test check that failed before it: - agy_body_archive no longer drops a clean round's closing </details> when the round quotes a standalone </details> or uses <details open>. - agy_cap_prompt checks the size first, so a prompt that already fits is not cut and the model is not told its diff was truncated. - agy_cut_file refuses a non-positive size rather than handing GNU `head -c -N` a negative count. - The self-test budget uses a pinned AGY_PRINT_TIMEOUT when one is set. - MAX_PROMPT_BYTES defaults to 120000 (its ceiling), ending the spurious clamp warning on every run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 396237db-fe77-4528-8d7a-171651720fe3) |
Template f492f3e's en-US conversion (behaviour, labelled, normalise -- normalise_numeric_env becomes normalize_numeric_env -- capitalisation, canonicalise*, artefact, summarises, (un)recognised, honour(s)), applied to this PR's copies without pulling in any other template change, plus the flow diagram's code fence labelled `text` (markdownlint MD040). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: f3c8b524-7ff9-40c6-baf6-ad24f68c08f4) |
What and why
This PR re-installs the Antigravity PR reviewer from the current antigravity-pr-review template (
b8501ed). The copy it replaces was an unmodified older template version: every overwritten file matched a template commit byte for byte. So nothing specific to this repo is lost, and the existing style guide (.github/agy-review.md) is kept.Fixes it brings:
iconv -cexits 1 whenever it drops bytes. That's exactly what happens after a byte cut, and the old code threwiconv's output away on failure, so the cleanup did nothing and agy could be handed a split UTF-8 sequence. It now falls back topython3, and one helper serves both the prompt and the review-output paths. The self-test covers it, including withiconvhidden..github/AGY-REVIEWER.md(the template README) is added or updated, and its file table now matches what the installer copies.Testing
bash scripts/agy-review-selftest.shpasses on this branch.actionlint .github/workflows/antigravity-review.ymlis clean.🤖 Generated with Claude Code
Note
Medium Risk
Changes who can trigger reviews on a self-hosted runner and how tokens are passed to git/GitHub APIs—security-sensitive CI paths—but behavior is fail-closed and heavily self-tested.
Overview
Replaces the repo’s Antigravity PR reviewer with the current antigravity-pr-review template: adds
.github/AGY-REVIEWER.md, refreshes the workflow and allscripts/*reviewer code, and leaves.github/agy-review.mdunchanged per the PR description.The workflow drops
issues: write, bumpstimeout-minutesto 45, and pins diff-size timeouts (AGY_TIMEOUT_SECONDS_PER_MIB: 900,AGY_PRINT_TIMEOUT_MAX_SECONDS: 900,AGY_RETRIES: 2,AGY_LOCK_WAIT: 300).agy-review.shgainsagy_has_write_access(GitHub permissions API for/agy-review, not justauthor_association), safer authenticatedgit fetchviaGIT_CONFIG_*instead of token-on-argv, local-diff fallback for both 20k-line and 300-filegh pr diff406s, shared truncation + UTF-8 scrub (agy_scrub_utf8with python3 when iconv “succeeds” but exits 1), diff-scaled print timeouts, stricter handling of backend errors, tool truncation notices, andagyprint timeouts (no green checks on junk output), plus richer logging instead of swallowed2>/dev/null. Review comments use a fixed edit-in-place archive (agy_assemble_archive, section sentinel) and reviewed-at metadata.agy-review-selftest.shgrows to execute regression tests for the above;_agy_print.shadds usage/readability checks.Reviewed by Cursor Bugbot for commit eb37110. Bugbot is set up for automated code reviews on this repo. Configure here.