Repository navigation
feat(image): add ninja to the runner images - #42
Merged
Merged
Conversation
Native Dart hooks need it: the dartcv4 hook of biokom-scan-app stops with "Failed to find ninja" on the large pool. Installing it in core gives every target the tool, and the smoke test now checks it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The four claims shared one home, so they raced to replace the same cache links and one could die on "ln: Already exists", failing the test at random. Runners have a home each, so the race only ever existed in the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Native Dart hooks need
ninja, and the image doesn't have it. Thedartcv4hook inbiokom-scan-appfails on thelargepool withFailed to find ninja with version=latest. Pull request builds only get past this because that repo installs it during the job.What
ninja-buildto thecorestage, next tocmakeandbuild-essential, sorunner,runner-ndkandrunner-slimall get it.ninjato the toolstests/image-smoke.shchecks.tests/slots.sh: the concurrent claims shared one home and raced on the same cache links, which failed this PR's first run. Each claim now has its own home, as real runners do.The package goes in the shared apt layer, so that layer is rebuilt once. The SDK and NDK layers don't change.
Testing
Not built locally. This PR's build job builds the images and runs the smoke test, which now checks
ninja.tests/slots.shneedsflock, so it runs in CI only;shellcheckpasses.Runners pick this up once the new image is deployed to the hosts.
🤖 Generated with Claude Code