Repository navigation
cmd/docker: Add guidance for unavailable offload commands - #7369
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
docker-agent
reviewed
Oct 9, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Show installation guidance and a documentation link when the offload plugin is missing or invalid. Handle this before command execution so plugin-specific flags and --help also receive the guidance. Signed-off-by: Nicolas Beck <nicolas.beck@docker.com>
nico1510
force-pushed
the
offload-plugin-guidance
branch
from
October 9, 2026 10:07
c29717a to
3e686a8
Compare
nico1510
marked this pull request as ready for review
October 9, 2026 10:08
docker-agent
reviewed
Oct 9, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to: #7358
Summary
Show installation guidance and a documentation link when
docker offloadcommands cannot find a usable plugin, instead of the generic unknown-command error. This also coversdocker offload --help, matching the guidance already provided for--cloud.Validated with
go test ./cmd/docker ./cli-plugins/managerand CLI checks for missing, invalid, and working plugins, including help behavior and exit codes.