Repository navigation
build: scope native-access and Unsafe JVM flags to the modules that need them - #537
Merged
Merged
Conversation
…tests need them The shared surefire argLine passed --enable-native-access and --sun-misc-unsafe-memory-access=allow to every module. They are now empty properties (test.native.args, test.unsafe.args) that reader, writer, parquet, cli and calcite opt into, each with a comment naming the caller that needs it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared surefire
argLinepassed--enable-native-access=ALL-UNNAMEDand--sun-misc-unsafe-memory-access=allowto every module. Both are now emptytest.native.args/test.unsafe.argsproperties in the root pom, set only where the unit tests trip the matching JDK warning:reader,writer: native access (our FFM zstd binding)parquet: native access (zstd-jniSystem.loadLibrary)cli: native access (PosixTerminal FFM) on top of its existing Unsafe flagcalcite: Unsafe (protobuf-java)Each property has a comment naming the caller. Failsafe (
integration) andbenchkeep their own flags, sincevortex-jni/Arrow need them../mvnw verifypasses and no restricted-method warning remains in any module. No CHANGELOG entry (build config).🤖 Generated with Claude Code