Skip to content

refactor: typed ScalarValue in encoder stats (#531) - #536

Open
dfa1 wants to merge 3 commits into
mainfrom
refactor/531-typed-stats
Open

dfa1 wants to merge 3 commits into
mainfrom
refactor/531-typed-stats

Conversation

@dfa1

@dfa1 dfa1 commented Oct 13, 2026

Copy link
Copy Markdown
Owner

Closes #531.

EncodeResult, CascadeStep, SegmentStats, and the min/max helpers (PrimitiveEncodingEncoder, ZoneMapStats, VarBinEncodingEncoder, ZoneMapStatCodec) carry ProtoScalarValue instead of serialized byte[]. Bytes are produced once, in buildArrayFlatBuffer. The array-record S6218 suppressions on the two carriers are gone. Sums stay byte[].

No wire change. ./mvnw test -pl writer -am and ./mvnw verify -pl integration -am pass. No CHANGELOG entry (internal refactor).

🤖 Generated with Claude Code

dfa1 and others added 3 commits October 13, 2026 08:21
…zed byte[] (#531)

EncodeResult, CascadeStep, SegmentStats and the min/max helpers now hold
ProtoScalarValue; serialization happens once at the FlatBuffer boundary
(VortexWriter#buildArrayFlatBuffer) and zone-map pruning reads the typed
value directly. No wire change.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EncodeResult stats: carry typed ScalarValue instead of serialized byte[]

1 participant