Repository navigation
CI: answer the dmg license prompt when mounting it in bundle-macos - #13
Merged
Merged
Conversation
bundle.licenseFile makes tauri-bundler embed the GPL as the dmg's license agreement; with no TTY, hdiutil attach cancels at that prompt, so "Verify the bundle" has failed on every run and the release job never ran.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bundle-macoshas failed in "Verify the bundle" on every run since the release pipeline landed (#9), so thereleasejob never ran and tag builds could not publish anything — the Flatpak included.Cause.
bundle.licenseFilemakes tauri-bundler pass--eulato create-dmg, embedding the GPL as the dmg's license agreement.hdiutil attachshows that agreement and waits for acceptance; with no TTY it cancels (hdiutil: attach canceled), afterhdiutil verifyhad already reported the image VALID.Fix. Feed the prompt:
yes | PAGER=cat hdiutil attach …. The shipped dmg is unchanged — users still see the GPL agreement on open.Verified on a manual run of the identical commit on
refactor/review-fixes(run 41823387567): all jobs green. With the mount working, the step's later checks ran for the first time and pass — the executable links only/usr/liband/System/Library, andcodesign --verify --deep --strictsucceeds (ad-hoc, hardened runtime).Not covered: the
releasejob itself only runs on av*tag.