Repository navigation
fix(php): Add Sury backports to PHP 7.3 Apache image - #10
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
wilcorrea
marked this pull request as ready for review
October 23, 2026 12:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
devitools/php-apache:7.3as a compatibility replacement forwebdevops/php-apache:7.3, applying Sury's backport for CVE-2026-109618 and CVE-2026-109619 plus its multipart-limit and string-length prerequisites.The existing image runs a source-built PHP under
/usr/local; installing Sury binary packages alongside it would not update FPM. This change extracts the three unmodified patches from a checksum-pinned Sury revision 35 source package, rebuilds CLI/FPM, sodium and OPcache using the original configure/compiler flags, and retains the pinned WebDevOps runtime, entrypoint, configuration paths, user, environment handling and other extensions. The patched source archive and headers also support downstream extension builds. Upload progress is disabled following the October 23 PHP advisory.The existing publication workflow will build the new amd64 tag after merge. A dedicated PR workflow builds the image and tests extension parity, normal Apache/FPM startup, HTTP, multipart upload, mounted INI configuration, environment settings, PHP_DISMOD, and immediate OOM exit with FPM recovery.
Validation: native linux/amd64 CI build and all compatibility/security smoke tests passed: https://github.com/devitools/dockerfile/actions/runs/39950711085. This includes exact CLI extension parity and matching FPM extensions (including its SAPI-specific cgi-fcgi module), Apache/FPM syntax and startup, HTTP, multipart upload, custom document root, mounted INI, PHP environment values, PHP_DISMOD, immediate CLI/FPM OOM exit without shutdown callbacks, and HTTP recovery after worker exit. Manifest validation, shell/Python syntax and diff checks also passed.
Scope: only the three named Sury patches are applied, not every fix in the full Sury package. PHP 7.3, Debian Buster and inherited third-party extension versions remain end of life. Encoded ionCube applications and application-specific compatibility still need staging validation. No containers are deployed by this PR.