Skip to content

fix(winrtble): open GATT services before characteristics discovery #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robdobsn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(winrtble): open GATT services before characteristics discovery #507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/winrtble/ble/device.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ use windows::{
BluetoothLEPreferredConnectionParameters,
GenericAttributeProfile::{
GattCharacteristic, GattCommunicationStatus, GattDescriptor, GattDeviceService,
GattDeviceServicesResult, GattSession,
GattDeviceServicesResult, GattSession, GattSharingMode,
},
},
Foundation::TypedEventHandler,
Expand Down Expand Up @@ -129,6 +129,16 @@ impl BLEDevice {
pub async fn get_characteristics(
service: &GattDeviceService,
) -> Result<Vec<GattCharacteristic>> {
// Some services refuse characteristic discovery (AccessDenied) until they have been
// opened. Opening shared doesn't stop other apps using the service, and if it fails
// discovery is still tried as before.
match service.OpenAsync(GattSharingMode::SharedReadAndWrite) {
Ok(op) => match op.await {
Ok(status) => trace!("service open status {:?}", status),
Err(e) => debug!("service open failed {:?}", e),
},
Err(e) => debug!("service open failed {:?}", e),
}
let async_result = match timeout(
GATT_CACHE_TIMEOUT,
service
Expand Down