Repository navigation
Conversation
- CI changepacks sync runs the version sync script from a copy taken from the main checkout, rewriting the branch checkout through VERSION_SYNC_ROOT, so branch-tree code never runs with the write token. cargo update only reads manifests (verified: no build script or proc macro runs). - README: a cfg-gated route module declared after vespera! is served but left out of the document. - component_schemas: the check_ambiguous_aliases doc is back on that function; documented_stored_route keeps its own doc. - rust_scope: a bare relative module file is anchored to the cwd, so a package-root lib.rs / models.rs layout gets its module path. `..` paths are not anchored. - merge_lookup: a renamed dependency whose app name the current crate also exports resolves to the unique other exporter before the current crate. - Tests: the harness-stem test asserts the sidecar stems differ; the default target-dir test clears VESPERA_TARGET_DIR / CARGO_TARGET_DIR. - axum-example: the garde profile doc names alphanumeric as the one rule without a JSON Schema equivalent (openapi.json description updated); the multipart WrongFieldType tests assert the error body. - bench-interleaved.sh clears its criterion output before the round loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A merge path whose first segment the current crate declares at its root (a `mod`, an item, or a `use .. as` name) resolves to the current crate's own export even when a renamed dependency exports the same app name. Only a segment the crate does not declare can be an extern crate, and only that case prefers the unique other exporter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
owjs3901
force-pushed
the
fix/macrorest-round30
branch
from
November 19, 2026 15:18
849f5f7 to
86b216b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Round-30 macro-rest findings (macrorest-0/2/5/6/7), each verified against the code before fixing:
.github/workflows/CI.yml): the version-PR sync script runs from a copy taken from the main checkout and rewrites the branch checkout throughVERSION_SYNC_ROOT, so branch-tree code never runs with the write token.cargo update --workspaceonly reads manifests (checked with a path dependency carrying a build script and a proc-macro crate; neither ran).#[cfg(..)]route module declared aftervespera!is served but left out of the OpenAPI document.check_ambiguous_aliasesdoc restored to that function;documented_stored_routekeeps its own doc.rust_scope::file_modules: a bare relative module file (models.rsat a package root) is anchored to the cwd, so it gets its module path...paths are not anchored.resolve_export: a renamed dependency whose app name the current crate also exports resolves to the unique other exporter before the current crate. Test:renamed_dependency_prefers_the_other_exporter_over_the_current_crate.VESPERA_TARGET_DIR/CARGO_TARGET_DIR.alphanumericas the one rule without a JSON Schema equivalent (openapi.jsondescription updated to match); the four status-only multipart tests and the non-UTF-8 test also assert theWrong type for fieldbody.scripts/bench-interleaved.sh: clears$work/criterionbefore the round loop.Changepack:
.changepacks/changepack_log_macrorest_round30.json(7 packages, Patch).Verification
cargo test -j 2 -p vespera_macro --lib: 5882 passedcargo clippy -j 2 -p vespera_macro --all-targets -- -D warnings: cleancargo test -j 2 -p axum-example --test integration_multipart: the edited tests passbun test scripts/: 73 pass; oxlint clean on the touched TS file;check-version-alignment.tspassesResolution note
A first segment the crate declares at its root (
mod routes, an item, ause .. asname) keeps the current crate. Only an undeclared first segment (an extern crate, e.g. a renamed dependency) prefers the unique other exporter.🤖 Generated with Claude Code