Repository navigation
Conversation
…erics)
Return-type aliases:
- A const argument written as a bare identifier (Page<LIMIT, User> for
type Page<const MAX: usize, T>) pairs with its const parameter and no
longer counts as a type argument, so the alias still expands.
Responses:
- An error response documents the HeaderMap headers the error sets (bare
or in the tuple) on its status, as the success side does. Snapshots for
the error-header cases now show "headers": {}.
Flatten:
- The module doc states the limit: with an opaque member that keeps the
object open, the flattened map's value schema is not emitted (JSON
Schema additionalProperties cannot see the member's keys). Nothing is
rejected.
- Test names and comments in serde_attrs (tag/content malformed values,
default substring) describe what they test.
Generic instances and inlining:
- A const argument of a nested type is part of its component name
(Tree<Buf<u8, 4>> and Tree<Buf<u8, 8>> no longer share Tree_Buf_u8).
- A const-only definition (Matrix<3>) inlines with its length.
- A const parameter named in value_type / into / from / try_from is
pinned by the instantiation like one named in a field type.
- value_type wins over #[schema(any)] on the same field, as the
wire_override module doc says; SchemaConstraints::any_decides is the
one check every any-suppression site uses.
Tests: every behaviour change has a test that fails without it (alias
const pairing rstest cases, error header snapshots, nested const
injectivity and recursive component tests, const-only inline, value_type
attribute length, value_type over any). The vacuous contains('B') in
aliased_non_schema_type_import_is_flagged now asserts `Query<B>`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
owjs3901
force-pushed
the
fix/parser-round30
branch
from
November 19, 2026 15:18
49b95b2 to
8d0d889
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Round-30 parser fixes (crates/vespera_macro/src/parser/**), each verified against the code before fixing:
Page<LIMIT, User>fortype Page<const MAX: usize, T>) pairs with its const parameter, so the alias expands.HeaderMapthe error sets documentsheaderson its status, like the success side. Four error-header snapshots updated ("headers": {}only).Tree<Buf<u8, 4>>vsTree<Buf<u8, 8>>).Matrix<3>) inline with their length; const parameters named invalue_type/into/from/try_fromattributes are pinned by the instantiation.value_typewins over#[schema(any)]on the same field, matching thewire_overridemodule doc.SchemaConstraints::any_decidesis the single check used by every any-suppression site.contains('B')assertion now checks`Query<B>`; misleadingserde_attrstest names and comments fixed.Every behaviour change has a test that fails without it.
Verification
cargo test -p vespera_macro(5894 lib tests, trybuild, doc-tests): pass.cargo test -p vespera: pass.cargo clippy -p vespera_macro --all-targets -- -D warnings: clean.cargo fmt --check: clean.conversion.rsis 986).Not changed
schema_assertions.rsleaf-type assertion still skips onanyeven when avalue_typeis present. That file is outside the parser scope; the skip is only a compile-time check, not an emitted schema.🤖 Generated with Claude Code