Repository navigation
Conversation
The benchmark refresh after #1002 recorded client bytes in benchmark-results.json, so the frozen e2e fixture (clientBytes: null) no longer fits typeof live and landing-next-e2e fails its type check on every pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closing as a duplicate of #1005, which fixes the same type error. 같은 타입 오류를 고치는 #1005와 중복이라 닫습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
landing-next-e2efails the Next type check on every pull request since the benchmark refreshdb5006294([skip ci], so main never ran it). The refresh recordedclientBytesandsizesas numbers inbenchmark-results.json, while the frozen e2e fixture keepsnull, sofixtureno longer fitstypeof live.benchmark-data.tsnow types the data by the fieldsBench.tsxreads (run.id/url/commit/next/devupUi/sha,samples, and per rowtable/target/version/median/bytes). Both files fit it, so a later refresh that adds fields cannot break the build again.Test
tsconbenchmark-data.tswithresolveJsonModule: one error (TS2322) on main, none with this change.요약
db5006294([skip ci]라 main에서는 실행되지 않음) 이후 모든 PR에서landing-next-e2e가 Next 타입 검사에서 실패합니다. refresh가benchmark-results.json에clientBytes와sizes를 숫자로 기록했는데, 고정된 e2e fixture는null이라fixture가 더 이상typeof live에 맞지 않습니다.benchmark-data.ts가Bench.tsx가 읽는 필드(run.id/url/commit/next/devupUi/sha,samples, 행마다table/target/version/median/bytes)로 데이터 타입을 정합니다. 두 파일 모두 맞으므로, 이후 refresh가 필드를 추가해도 빌드가 다시 깨지지 않습니다.테스트
resolveJsonModule로benchmark-data.ts에tsc실행: main에서는 오류 1개(TS2322), 이 변경에서는 없음.🤖 Generated with Claude Code