Skip to content

fix(landing): type the benchmark data by the fields the page reads - #1006

Closed
owjs3901 wants to merge 1 commit into
mainfrom
fix/landing-benchmark-data-type
Closed

owjs3901 wants to merge 1 commit into
mainfrom
fix/landing-benchmark-data-type

Conversation

@owjs3901

Copy link
Copy Markdown
Contributor

Summary

  • landing-next-e2e fails the Next type check on every pull request since the benchmark refresh db5006294 ([skip ci], so main never ran it). The refresh recorded clientBytes and sizes as numbers in benchmark-results.json, while the frozen e2e fixture keeps null, so fixture no longer fits typeof live.
  • benchmark-data.ts now types the data by the fields Bench.tsx reads (run.id/url/commit/next/devupUi/sha, samples, and per row table/target/version/median/bytes). Both files fit it, so a later refresh that adds fields cannot break the build again.

Test


요약

  • benchmark refresh db5006294([skip ci]라 main에서는 실행되지 않음) 이후 모든 PR에서 landing-next-e2e가 Next 타입 검사에서 실패합니다. refresh가 benchmark-results.json에 clientBytes와 sizes를 숫자로 기록했는데, 고정된 e2e fixture는 null이라 fixture가 더 이상 typeof live에 맞지 않습니다.
  • benchmark-data.ts가 Bench.tsx가 읽는 필드(run.id/url/commit/next/devupUi/sha, samples, 행마다 table/target/version/median/bytes)로 데이터 타입을 정합니다. 두 파일 모두 맞으므로, 이후 refresh가 필드를 추가해도 빌드가 다시 깨지지 않습니다.

테스트

🤖 Generated with Claude Code

The benchmark refresh after #1002 recorded client bytes in benchmark-results.json,
so the frozen e2e fixture (clientBytes: null) no longer fits typeof live and
landing-next-e2e fails its type check on every pull request.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@owjs3901

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #1005, which fixes the same type error.


같은 타입 오류를 고치는 #1005와 중복이라 닫습니다.

@owjs3901 owjs3901 closed this Nov 18, 2026
@owjs3901
owjs3901 deleted the fix/landing-benchmark-data-type branch November 18, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant