Repository navigation
feat(ssoapplication): add SAML single logout and OIDC logout propagation options - #834
Merged
Merged
Conversation
Add the SAML Single Logout (SLO) options to SAML applications: singleLogoutEnabled, spSingleLogoutUrl, spSingleLogoutBinding, singleLogoutPropagation and singleLogoutScope. They are sent only when set, so an update that leaves them out keeps the application's current values; load returns them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
🐕 Shuni ReviewNo new issues found. Approval outcome: APPROVED 🤖 Model: Review scope: Partial incremental re-review Reviewed new changes (1)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
…ions The backend now takes the SAML single logout settings as plain fields, like the rest of the application: an update that leaves them out turns single logout off, rather than keeping the current values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
logoutPropagation ("allApps" default, or "none") on OIDC application options and settings: how far a
logout at the app's end-session endpoint reaches.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Descope no longer records which applications a session reached, so a logout that reaches the user's applications sends a LogoutRequest to every SLO application the user can sign in to, naming the user by its NameID. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Type the loaded SAML SLO binding, propagation and scope with the same literal unions as SamlApplicationOptions, so a loaded value can be passed back to an update. Say that logouts without a browser reach only SOAP SLO applications, and fix the README example's SLO trigger. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An application's own logout reaches the user's other applications only when it sets propagation to "allApps". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…en the project enables it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add notifyOnForceLogout to the SAML and OIDC application options and loaded settings. When on, a force logout of the user (the Console's, or the management API's logout of all of a user's devices) notifies the app: an OIDC app with a back-channel logout URL is sent a logout token, a SAML app with single logout over SOAP a LogoutRequest. Off by default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Name the user's own logout of all devices as the one that always reaches SLO applications. A force logout (including the management API's logout of all of a user's devices) reaches an app only when its notifyOnForceLogout is on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OIDC app options and the loaded OIDC settings get backChannelLogoutUrl, so notifyOnForceLogout can take effect through the SDK and an update can keep the app's URL. The SLO docs describe the default SP binding and that 'allApps' reaches OIDC apps only when every session of the user ended. The load fixture and a create test cover the SAML SLO fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ut scope ends Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t scope description Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…scope Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Required for:
https://github.com/descope/etc/issues/19980
Related PRs
Description
SAML applications get the SAML Single Logout (SLO) settings: turn SLO on, the service provider's logout URL and binding, how far a logout started by the service provider reaches, and which sessions it ends. Like the other options, an update that leaves them out turns SLO off. An empty
spSingleLogoutBindingis the default: with anspSingleLogoutUrl, HTTP-Redirect; without one, from the service provider's metadata (SOAP when it offers an https SOAP endpoint, else HTTP-Redirect, else HTTP-POST). WithsingleLogoutPropagation: 'allApps', OIDC apps are reached only when every session of the user ended.OIDC apps:
OidcApplicationOptionsandSSOApplicationOIDCSettingsgetlogoutPropagation('none'default, or'allApps'): how far a logout at the app's end-session endpoint reaches. They also getbackChannelLogoutUrl, the app's OIDC back-channel logout URL. Like the other options, an update that leaves it out clears it.Force logout:
SamlApplicationOptions,OidcApplicationOptionsand the loadedSSOApplicationSAMLSettings/SSOApplicationOIDCSettingsgetnotifyOnForceLogout(off by default): whether a force logout of the user (the Console's, or the management API's logout of all of a user's devices) notifies the app. An OIDC app with a back-channel logout URL is sent a logout token, a SAML app with single logout over SOAP a LogoutRequest. Like the other options, an update that leaves it out turns it off.In a Nutshell
SamlApplicationOptions:singleLogoutEnabled,spSingleLogoutUrl,spSingleLogoutBinding,singleLogoutPropagation,singleLogoutScope(SLO off by default),notifyOnForceLogoutOidcApplicationOptions:logoutPropagation,backChannelLogoutUrl,notifyOnForceLogoutSSOApplicationSAMLSettings/SSOApplicationOIDCSettings: the same settings on loadnotifyOnForceLogoutexample setsbackChannelLogoutUrl)Must
🤖 Generated with Claude Code