Skip to content

feat(ssoapplication): add SAML single logout and OIDC logout propagation options - #834

Merged
dorsha merged 13 commits into
mainfrom
feat/saml-app-single-logout
Nov 10, 2026
Merged

dorsha merged 13 commits into
mainfrom
feat/saml-app-single-logout

Conversation

@dorsha

@dorsha dorsha commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Related Issues

Required for:
https://github.com/descope/etc/issues/19980

Related PRs

Description

SAML applications get the SAML Single Logout (SLO) settings: turn SLO on, the service provider's logout URL and binding, how far a logout started by the service provider reaches, and which sessions it ends. Like the other options, an update that leaves them out turns SLO off. An empty spSingleLogoutBinding is the default: with an spSingleLogoutUrl, HTTP-Redirect; without one, from the service provider's metadata (SOAP when it offers an https SOAP endpoint, else HTTP-Redirect, else HTTP-POST). With singleLogoutPropagation: 'allApps', OIDC apps are reached only when every session of the user ended.

OIDC apps: OidcApplicationOptions and SSOApplicationOIDCSettings get logoutPropagation ('none' default, or 'allApps'): how far a logout at the app's end-session endpoint reaches. They also get backChannelLogoutUrl, the app's OIDC back-channel logout URL. Like the other options, an update that leaves it out clears it.

Force logout: SamlApplicationOptions, OidcApplicationOptions and the loaded SSOApplicationSAMLSettings / SSOApplicationOIDCSettings get notifyOnForceLogout (off by default): whether a force logout of the user (the Console's, or the management API's logout of all of a user's devices) notifies the app. An OIDC app with a back-channel logout URL is sent a logout token, a SAML app with single logout over SOAP a LogoutRequest. Like the other options, an update that leaves it out turns it off.

In a Nutshell

  • SamlApplicationOptions: singleLogoutEnabled, spSingleLogoutUrl, spSingleLogoutBinding, singleLogoutPropagation, singleLogoutScope (SLO off by default), notifyOnForceLogout
  • OidcApplicationOptions: logoutPropagation, backChannelLogoutUrl, notifyOnForceLogout
  • SSOApplicationSAMLSettings / SSOApplicationOIDCSettings: the same settings on load
  • README examples (the OIDC notifyOnForceLogout example sets backChannelLogoutUrl)

Must

  • Tests
  • Documentation (if applicable)

🤖 Generated with Claude Code

Add the SAML Single Logout (SLO) options to SAML applications:
singleLogoutEnabled, spSingleLogoutUrl, spSingleLogoutBinding,
singleLogoutPropagation and singleLogoutScope. They are sent only when set, so
an update that leaves them out keeps the application's current values; load
returns them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

🐕 Shuni Review

No new issues found.

Approval outcome: APPROVED
Reason: Cumulative full review completed across trusted review history with no findings and clear review threads.

🤖 Model: claude-opus-5.5 · Effort: high


Review scope: Partial incremental re-review

Reviewed new changes (1)
  • lib/management/types.ts
Previously reviewed and unchanged: 2 files.

🐕 Review complete — View session on Shuni Portal 🐾

🤖 Model: claude-opus-5.5 · Effort: high

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: 1 inline finding. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Comment thread lib/management/types.ts Resolved
…ions

The backend now takes the SAML single logout settings as plain fields, like the
rest of the application: an update that leaves them out turns single logout
off, rather than keeping the current values.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

logoutPropagation ("allApps" default, or "none") on OIDC application options and settings: how far a
logout at the app's end-session endpoint reaches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@dorsha dorsha changed the title feat(ssoapplication): SAML application single logout options feat(ssoapplication): add SAML single logout and OIDC logout propagation options Nov 9, 2026
Descope no longer records which applications a session reached, so a logout
that reaches the user's applications sends a LogoutRequest to every SLO
application the user can sign in to, naming the user by its NameID.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: 1 inline finding. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Comment thread README.md Resolved
Type the loaded SAML SLO binding, propagation and scope with the same literal
unions as SamlApplicationOptions, so a loaded value can be passed back to an
update. Say that logouts without a browser reach only SOAP SLO applications,
and fix the README example's SLO trigger.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shuni-bot[bot]
shuni-bot Bot previously approved these changes Nov 9, 2026

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

An application's own logout reaches the user's other applications only when it
sets propagation to "allApps".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shuni-bot[bot]
shuni-bot Bot previously approved these changes Nov 9, 2026

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

…en the project enables it

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shuni-bot[bot]
shuni-bot Bot previously approved these changes Nov 9, 2026

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Add notifyOnForceLogout to the SAML and OIDC application options and
loaded settings. When on, a force logout of the user (the Console's, or
the management API's logout of all of a user's devices) notifies the
app: an OIDC app with a back-channel logout URL is sent a logout token,
a SAML app with single logout over SOAP a LogoutRequest. Off by default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: 1 inline finding. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Comment thread lib/management/types.ts Resolved
Name the user's own logout of all devices as the one that always
reaches SLO applications. A force logout (including the management
API's logout of all of a user's devices) reaches an app only when its
notifyOnForceLogout is on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shuni-bot[bot]
shuni-bot Bot previously approved these changes Nov 10, 2026

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

OIDC app options and the loaded OIDC settings get backChannelLogoutUrl, so
notifyOnForceLogout can take effect through the SDK and an update can keep
the app's URL. The SLO docs describe the default SP binding and that
'allApps' reaches OIDC apps only when every session of the user ended. The
load fixture and a create test cover the SAML SLO fields.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shuni-bot[bot]
shuni-bot Bot previously approved these changes Nov 10, 2026

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

…ut scope ends

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shuni-bot[bot]
shuni-bot Bot previously approved these changes Nov 10, 2026

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

…t scope description

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: 1 inline finding. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Comment thread lib/management/types.ts Resolved
…scope

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@dorsha
dorsha merged commit e1c4fd9 into main Nov 10, 2026
26 checks passed
@dorsha
dorsha deleted the feat/saml-app-single-logout branch November 10, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant