Repository navigation
Conversation
Contributor
🐕 Shuni ReviewNo new issues found. Approval outcome: APPROVED 🤖 Model: Review scope: Partial incremental re-review Reviewed new changes (4)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Required for:
https://github.com/descope/etc/issues/19999
Description
Enchanted link sign-in, sign-up, verify and user update calls can now choose the delivery provider, message template, SSO app, recovery address and locale, and the session response returns the full user and token details the server sends.
Shared code:
SignInRequest,SignUpRequest,UpdateEmailRequest,UpdatePhoneRequest,VerifyRequest) gained nullable fields; magic link never sets them and nulls are not serialized, so its request bodies are unchanged.JWTResponse,AuthenticationInfo(filled by the sharedAuthenticationsBase.getAuthenticationInfo),UserResponseandIDPResponsegained fields, additive only, so every auth method now gets them when the server sends them.UserResponse.oAuthalso reads the server'sOAuthkey via@JsonAlias; theoauthkey is still read and serialization is unchanged.Backwards compatibility:
EnchantedLinkServicemethods are kept and delegate to the new overloads with null for the new arguments.Interface and enum additions:
EnchantedLinkServicegains overloads ofsignIn,signInWithPhone,signUp,signUpWithPhone,signUpOrIn,signUpOrInWithPhone,updateUserEmail,updateUserPhoneandverify(token, pkceVerifier); no enum changes.In a Nutshell
POST /v1/auth/enchantedlink/signin/email->signIn(providerId, ssoAppId, useRecovery)POST /v1/auth/enchantedlink/signin/sms->signInWithPhone(providerId, ssoAppId, useRecovery)POST /v1/auth/enchantedlink/signup-in/email->signUpOrIn(providerId, ssoAppId, useRecovery)POST /v1/auth/enchantedlink/signup-in/sms->signUpOrInWithPhone(providerId, ssoAppId, useRecovery)POST /v1/auth/enchantedlink/signup/email->signUp(providerId, templateId)POST /v1/auth/enchantedlink/signup/sms->signUpWithPhone(providerId, templateId)POST /v1/auth/enchantedlink/update/email->updateUserEmail(providerId, templateId, locale, failOnConflict)POST /v1/auth/enchantedlink/update/phone/sms->updateUserPhone(providerId, templateId, locale, failOnConflict)POST /v1/auth/enchantedlink/verify->verify(pkceVerifier)POST /v1/auth/enchantedlink/pending-session->getSession(new JWT, user and IDP response fields)Must
Generated by Descope SDK Agent 🤖🌟