Skip to content

feat(auth): add email verification start - #450

Open
yosiharan wants to merge 1 commit into
mainfrom
sdk-update/v1-auth-emailverification-20261120-120218
Open

yosiharan wants to merge 1 commit into
mainfrom
sdk-update/v1-auth-emailverification-20261120-120218

Conversation

@yosiharan

Copy link
Copy Markdown
Contributor

Related Issues

Required for:
https://github.com/descope/etc/issues/19999

Description

The SDK can now start email verification, returning the single-use nonce for a sign-in page's hidden email-verification-token input.

Interface and enum additions:

  • New public interface EmailVerificationService with String start(), mirroring how OAuth/SSO start return a value directly
  • AuthenticationServices gains emailVerificationService, wired in AuthenticationServiceBuilder (additive getter/builder method, binary compatible)

Also: the endpoint takes a body with no properties, so start() sends {}, as AuthzServiceImpl does for body-less POSTs.

In a Nutshell

  • POST /v1/auth/emailverification/start -> EmailVerificationService.start() (new EmailVerificationStartResponse model; README gains an Email Verification section)

Must

  • Tests
  • Documentation (if applicable)

Generated by Descope SDK Agent 🤖🌟

@shuni-bot

shuni-bot Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

🐕 Shuni Review

No new issues found.

Approval outcome: APPROVED
Reason: Full review completed with no findings and clear review threads.

🤖 Model: claude-opus-5.5 · Effort: medium


Review scope: Full review

Reviewed files (8)
  • README.md
  • src/main/java/com/descope/literals/Routes.java
  • src/main/java/com/descope/model/auth/AuthenticationServices.java
  • src/main/java/com/descope/model/auth/EmailVerificationStartResponse.java
  • src/main/java/com/descope/sdk/auth/EmailVerificationService.java
  • src/main/java/com/descope/sdk/auth/impl/AuthenticationServiceBuilder.java
  • src/main/java/com/descope/sdk/auth/impl/EmailVerificationServiceImpl.java
  • src/test/java/com/descope/sdk/auth/impl/EmailVerificationServiceImplTest.java

🐕 Review complete — View session on Shuni Portal 🐾

🤖 Model: claude-opus-5.5 · Effort: medium

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant