Repository navigation
Conversation
Contributor
🐕 Shuni ReviewNo new issues found. Approval outcome: APPROVED 🤖 Model: Review scope: Full review Reviewed files (6)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
yosiharan
marked this pull request as draft
November 20, 2026 10:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Required for:
https://github.com/descope/etc/issues/19999
Description
The SDK can now return the ID of an exchanged access key alongside the session token.
Shared code:
exchangeAccessKey(accessKey, loginOptions)now delegates to the new method and returns its token: same validation, route, credential and body, so callers get the sameToken.Backwards compatibility:
exchangeAccessKeymethods keep theirTokenreturn type; the key ID comes through new methods instead.ExchangeAccessKeyResponseextendsJWTResponse, soJWTResponseand its constructors are untouched.Interface and enum additions:
AuthenticationServicegainsexchangeAccessKeyAuthenticationInfo(String)andexchangeAccessKeyAuthenticationInfo(String, AccessKeyLoginOptions), returning the newAccessKeyAuthenticationInfo(token +keyId).Also: the README gains an "Exchanging an Access Key" snippet.
In a Nutshell
POST /v1/auth/accesskey/exchange->AuthenticationService.exchangeAccessKeyAuthenticationInfo(gainskeyId)Must
Generated by Descope SDK Agent 🤖🌟