Repository navigation
Conversation
Contributor
🐕 Shuni ReviewNo new issues found. Approval outcome: APPROVED 🤖 Model: Review scope: Partial incremental re-review Reviewed new changes (7)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
yosiharan
marked this pull request as draft
November 19, 2026 23:44
Contributor
Author
|
[DESCOPE-SDK-AGENT 🤖] Closing: this run is superseded by a fresh SDK agent run with an updated harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Required for:
https://github.com/descope/etc/issues/19999
Description
The OTP service can now send codes over IM and pass the provider, template, SSO app, recovery and tenant options the OTP API accepts.
Shared code:
AuthenticationsBase.verifyDeliveryMethod/getMaskedValuetreatIMlike the phone methods; magic link sign-in/up andgenerateOtpForTestUser/generateMagicLinkForTestUserrejectIMbefore sending, since those APIs have no IM route.LoginOptions,SignUpOptions,UserandUpdateOptionsgain optional fields that stay null and are omitted, so existing requests are unchanged; theUpdateOptionsadditions are sent by OTP updates only.UserResponse,AssociatedTenant,IDPResponse,JWTResponseandAuthenticationInfogain response fields;UserResponsenow also readsTOTP/SAML/OAuthas spelled by the API (it previously read only the lower-case names), andAssociatedTenant.permissions/roleIdsare read-only so tenants passed back to the user and access key APIs send what they did before.Backwards compatibility:
OTPServiceoverloads delegate to the new ones withnulland send the same requests.Interface and enum additions:
OTPService.signIn(..., OTPSignInOptions),signUp(..., OTPSignUpOptions)andsignUpOrIn(deliveryMethod, loginId, LoginOptions, OTPSignInOptions).DeliveryMethod.IM("im"), OTP only.OTPSignInOptions(providerId, templateId, ssoAppId, useRecovery),OTPSignUpOptions(providerId, templateId) andUserFamily.In a Nutshell
POST /v1/auth/otp/signin/im->OTPService.signIn(DeliveryMethod.IM, ...)POST /v1/auth/otp/signup-in/im->OTPService.signUpOrIn(DeliveryMethod.IM, ...)POST /v1/auth/otp/signup/im->OTPService.signUp(DeliveryMethod.IM, ...)POST /v1/auth/otp/update/phone/im->OTPService.updateUserPhone(DeliveryMethod.IM, ...)POST /v1/auth/otp/verify/im->OTPService.verifyCode(DeliveryMethod.IM, ...)POST /v1/auth/otp/signin/{email,sms,voice,whatsapp}->OTPService.signIn: providerId, templateId, ssoAppId, useRecovery, loginOptions.ssoAppId/pkceChallenge/tenantIdPOST /v1/auth/otp/signup-in/{email,sms,voice,whatsapp}->OTPService.signUpOrIn: loginOptions, providerId, templateId, ssoAppId, useRecoveryPOST /v1/auth/otp/signup/{email,sms,voice}->OTPService.signUp: providerId, templateId, user.loginId/recoveryEmail/recoveryPhone, loginOptions.locale/pkceChallenge/templateId/tenantIdPOST /v1/auth/otp/update/email,POST /v1/auth/otp/update/phone/{sms,voice,whatsapp}->OTPService.updateUserEmail/updateUserPhone: providerId, templateId, locale, failOnConflict, mfaPOST /v1/auth/otp/verify/{email,sms,voice,whatsapp}->OTPService.verifyCode: newAuthenticationInforesponse fields (cookie settings, sessionExpiration, externalToken, claims, trustedDeviceJwt, and more)Must
Generated by Descope SDK Agent 🤖🌟