Repository navigation
Conversation
Contributor
🐕 Shuni ReviewNo new issues found. Approval outcome: APPROVED 🤖 Model: Review scope: Full review Reviewed files (15)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
yosiharan
marked this pull request as draft
November 19, 2026 22:52
Contributor
Author
|
[DESCOPE-SDK-AGENT 🤖] Closing: this run is superseded by a fresh SDK agent run with an updated harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Required for:
https://github.com/descope/etc/issues/19999
Description
The OAuth service can now pass prompt, login hint and initiated email when starting an OAuth flow, link an OAuth provider to a logged-in user, and returns the full set of authentication response fields.
Shared code:
LoginOptionsgainsssoAppId,pkceChallengeandtenantId, omitted when unset, so other auth methods send the same body unless a caller sets them.AuthenticationsBase.getAuthenticationInfo(used by every verify/exchange/refresh method) also copies the newJWTResponsefields; existing fields and JWT validation are unchanged.AssociatedTenantgainspermissionsandroleIdsas read-only, so mgmt request bodies that use it are unchanged.Backwards compatibility:
LoginOptions,JWTResponse,AuthenticationInfo,IDPResponseandUserResponseare kept as explicit overloads (japicmp reports no changes).start/startSignIn/startSignUpoverloads are untouched; the new behavior is only in the new overloads.Interface and enum additions:
OAuthServicegainsstart/startSignIn/startSignUpoverloads takingOAuthAuthorizeOptions, and twoupdateUseroverloads.OAuthAuthorizeOptions, enumOAuthPrompt(NONE,LOGIN,CONSENT,SELECT_ACCOUNT),UserFamily.Also:
UserResponse.TOTP/SAML/OAuthnow also deserialize from the upper-case keys the API sends (via@JsonAlias), so values that were always null are now filled for auth and mgmt users alike; serialization keys are unchanged.In a Nutshell
POST /v1/auth/oauth/authorize->OAuthService.start(new overload:OAuthAuthorizeOptions)POST /v1/auth/oauth/authorize/signin->OAuthService.startSignIn(new overload:OAuthAuthorizeOptions)POST /v1/auth/oauth/authorize/signup->OAuthService.startSignUp(new overload:OAuthAuthorizeOptions)POST /v1/auth/oauth/authorize/update->OAuthService.updateUserPOST /v1/auth/oauth/exchange->OAuthService.exchangeToken(AuthenticationInfogains the new session, cookie and user fields)Must
Generated by Descope SDK Agent 🤖🌟