Repository navigation
Conversation
Contributor
🐕 Shuni ReviewNo new issues found. Approval outcome: APPROVED 🤖 Model: Review scope: Partial incremental re-review Reviewed new changes (3)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
yosiharan
marked this pull request as draft
November 19, 2026 22:09
Contributor
Author
|
[DESCOPE-SDK-AGENT 🤖] Closing: this run is superseded by a fresh SDK agent run with an updated harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Required for:
https://github.com/descope/etc/issues/19999
Description
Magic link sign-in, sign-up, sign-up-or-in and update calls can now pass the provider, template, SSO app, tenant, locale and recovery options the API accepts, and verify returns the full session response.
Client-side validation:
signUpwithMagicLinkSignUpOptions.phoneandDeliveryMethod.EMAILthrows an invalid-argument error before sending.Shared code:
LoginOptions(+ssoAppId,pkceChallenge,tenantId) andSignUpOptions(+locale,pkceChallenge,templateId,tenantId) are also used by OTP, enchanted link, password, TOTP, WebAuthn, OAuth/SAML/SSO and mgmt embedded/test links; the new fields are omitted unless set.UpdateOptionsgainsproviderId,templateId,locale,failOnConflict: only the magic link update methods send them, OTP and enchanted link ignore them.AssociatedTenant+permissions/roleIdsare write-only so mgmt user create/patch never sends them.AuthenticationsBase.getAuthenticationInfo(every verify/exchange/refresh) copies the newJWTResponsefields ontoAuthenticationInfo; existing getters are unchanged.Backwards compatibility:
LoginOptions,SignUpOptions,UpdateOptions,User,JWTResponse,AuthenticationInfoand the request models are kept; japicmp reports no binary incompatibility.MagicLinkServiceoverloads delegate withnulland send the same body as before.Interface and enum additions:
MagicLinkService: new overloadssignIn(..., LoginOptions, MagicLinkSignInOptions),signUpOrIn(deliveryMethod, loginId, uri, LoginOptions, MagicLinkSignInOptions),signUp(..., SignUpOptions, MagicLinkSignUpOptions).MagicLinkSignInOptions,MagicLinkSignUpOptions,UserFamily.Also:
UserResponse(all mgmt user responses too) now mapsTOTP/SAML/OAuthvia@JsonProperty; they were always null before and now serialize under those names, a visible change for callers who re-serializeUserResponse.In a Nutshell
POST /v1/auth/magiclink/signin/{email,sms,whatsapp}->MagicLinkService.signIn(gainsproviderId,templateId,ssoAppId,useRecovery;loginOptionsgainsssoAppId,pkceChallenge,tenantId)POST /v1/auth/magiclink/signup-in/{email,sms,whatsapp}->MagicLinkService.signUpOrIn(gainsloginOptions,providerId,templateId,ssoAppId,useRecovery)POST /v1/auth/magiclink/signup/{email,sms,whatsapp}->MagicLinkService.signUp(gainsphone,providerId,templateId;loginOptionsgainslocale,pkceChallenge,templateId,tenantId;usergainsloginId,recoveryEmail,recoveryPhone)POST /v1/auth/magiclink/update/email->MagicLinkService.updateUserEmail(gainsproviderId,templateId,locale,failOnConflict)POST /v1/auth/magiclink/update/phone/{sms,whatsapp}->MagicLinkService.updateUserPhone(gainsproviderId,templateId,locale,failOnConflict)POST /v1/auth/magiclink/verify->MagicLinkService.verify(AuthenticationInfogains the cookie, session expiration, claims, SSO and device JWT response fields;UserResponsegains the spec's user fields)Must
Generated by Descope SDK Agent 🤖🌟