Repository navigation
Conversation
Contributor
🐕 Shuni ReviewNo new issues found. Approval outcome: APPROVED 🤖 Model: Review scope: Full review Reviewed files (6)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
yosiharan
marked this pull request as draft
November 19, 2026 21:21
Contributor
Author
|
[DESCOPE-SDK-AGENT 🤖] Closing: this run is superseded by a fresh SDK agent run with an updated harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Required for:
https://github.com/descope/etc/issues/19999
Description
The SDK can now log out of all device sessions limited to given logout types, and returns the server's response with the cookie settings to clear.
Shared code:
JWTResponsegains 13 response fields (sessionExpiration,claims,cookieName,sessionCookieName,sessionCookieDomain, and others). Every auth flow deserializes it, butgetAuthenticationInfoonly reads the existing fields, so they are unaffected.equals/hashCode/toStringnow include the new fields.Backwards compatibility:
void logoutAll(String)is unchanged and still sends no body.idpResponse) constructor is now explicit next to the existing 8-arg one.Interface and enum additions:
AuthenticationServiceinterface:JWTResponse logoutAll(String refreshToken, List<String> logoutType).In a Nutshell
POST /v1/auth/logoutall->AuthenticationService.logoutAll(String refreshToken, List<String> logoutType)(new overload,logoutTypeomitted when null)Must
Generated by Descope SDK Agent 🤖🌟