Skip to content

feat(auth): log out of all sessions by logout type - #445

Closed
yosiharan wants to merge 2 commits into
mainfrom
sdk-update/v1-auth-logoutall-20261119-224536
Closed

yosiharan wants to merge 2 commits into
mainfrom
sdk-update/v1-auth-logoutall-20261119-224536

Conversation

@yosiharan

Copy link
Copy Markdown
Contributor

Related Issues

Required for:
https://github.com/descope/etc/issues/19999

Description

The SDK can now log out of all device sessions limited to given logout types, and returns the server's response with the cookie settings to clear.

Shared code:

  • JWTResponse gains 13 response fields (sessionExpiration, claims, cookieName, sessionCookieName, sessionCookieDomain, and others). Every auth flow deserializes it, but getAuthenticationInfo only reads the existing fields, so they are unaffected.
  • Lombok equals/hashCode/toString now include the new fields.

Backwards compatibility:

  • The existing void logoutAll(String) is unchanged and still sends no body.
  • The all-args constructor grows to 22 args, so the previous 9-arg (with idpResponse) constructor is now explicit next to the existing 8-arg one.

Interface and enum additions:

  • New method on the public AuthenticationService interface: JWTResponse logoutAll(String refreshToken, List<String> logoutType).

In a Nutshell

  • POST /v1/auth/logoutall -> AuthenticationService.logoutAll(String refreshToken, List<String> logoutType) (new overload, logoutType omitted when null)

Must

  • Tests
  • Documentation (if applicable)

Generated by Descope SDK Agent 🤖🌟

@shuni-bot

shuni-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

🐕 Shuni Review

No new issues found.

Approval outcome: APPROVED
Reason: Full review completed with no findings and clear review threads.

🤖 Model: claude-opus-5.5 · Effort: medium


Review scope: Full review

Reviewed files (6)
  • README.md
  • src/main/java/com/descope/model/auth/LogoutRequest.java
  • src/main/java/com/descope/model/jwt/response/JWTResponse.java
  • src/main/java/com/descope/sdk/auth/AuthenticationService.java
  • src/main/java/com/descope/sdk/auth/impl/AuthenticationServiceImpl.java
  • src/test/java/com/descope/sdk/auth/impl/AuthenticationServiceImplTest.java

🐕 Review complete — View session on Shuni Portal 🐾

🤖 Model: claude-opus-5.5 · Effort: medium

shuni-bot[bot]
shuni-bot Bot previously approved these changes Nov 19, 2026

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@yosiharan

Copy link
Copy Markdown
Contributor Author

[DESCOPE-SDK-AGENT 🤖] Closing: this run is superseded by a fresh SDK agent run with an updated harness.

@yosiharan yosiharan closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant