Skip to content

feat(auth): pass logout types when logging out - #444

Closed
yosiharan wants to merge 1 commit into
mainfrom
sdk-update/v1-auth-logout-20261119-222647
Closed

yosiharan wants to merge 1 commit into
mainfrom
sdk-update/v1-auth-logout-20261119-222647

Conversation

@yosiharan

Copy link
Copy Markdown
Contributor

Related Issues

Required for:
https://github.com/descope/etc/issues/19999

Description

The auth SDK can now send logout types with a logout request.

Backwards compatibility:

  • logout(String) is unchanged and still sends no body; the new overload does not route through it.

Interface and enum additions:

  • AuthenticationService.logout(String, List<String>): custom implementations or mocks of the interface must add it.
  • New model com.descope.model.auth.LogoutRequest.

Also: The new overload always sends a JSON body ({} when logoutType is null).

In a Nutshell

  • POST /v1/auth/logout -> AuthenticationService.logout(refreshToken, logoutType) (new overload with logoutType)

Must

  • Tests
  • Documentation (if applicable)

Generated by Descope SDK Agent 🤖🌟

@shuni-bot

shuni-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

🐕 Shuni Review

No new issues found.

Approval outcome: APPROVED
Reason: Full review completed with no findings and clear review threads.

🤖 Model: claude-opus-5.5 · Effort: medium


Review scope: Full review

Reviewed files (5)
  • README.md
  • src/main/java/com/descope/model/auth/LogoutRequest.java
  • src/main/java/com/descope/sdk/auth/AuthenticationService.java
  • src/main/java/com/descope/sdk/auth/impl/AuthenticationServiceImpl.java
  • src/test/java/com/descope/sdk/auth/impl/AuthenticationServiceImplTest.java

🐕 Review complete — View session on Shuni Portal 🐾

🤖 Model: claude-opus-5.5 · Effort: medium

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@yosiharan

Copy link
Copy Markdown
Contributor Author

[DESCOPE-SDK-AGENT 🤖] Closing: this run is superseded by a fresh SDK agent run with an updated harness.

@yosiharan yosiharan closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant