Repository navigation
Conversation
Contributor
🐕 Shuni ReviewNo new issues found. Approval outcome: APPROVED 🤖 Model: Review scope: Full review Reviewed files (22)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
yosiharan
marked this pull request as draft
November 19, 2026 20:26
Contributor
Author
|
[DESCOPE-SDK-AGENT 🤖] Closing: this run is superseded by a fresh SDK agent run with an updated harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Required for:
https://github.com/descope/etc/issues/19999
Description
The enchanted link API now covers every request and response field of the enchanted link endpoints: provider and template selection, SSO app sign-in, recovery, PKCE, and conflict handling on updates.
Shared code:
LoginOptions,SignUpOptions,UpdateOptions,Userand the shared request classes gain fields; they default to null and are omitted, so magic link, OTP, password and mgmt request bodies are unchanged.AuthenticationsBase.getAuthenticationInfocopies the newJWTResponsefields (cookie settings, claims, external token, device JWTs, etc.) intoAuthenticationInfofor every auth method; existing fields are unchanged.AssociatedTenant.permissionsandroleIdsare deserialize-only, since the class is also sent in mgmt user create/patch requests.Backwards compatibility:
EnchantedLinkServicemethods are kept and delegate to the new overloads with null options;signUpOrInwith no options sends the same body as before.Interface and enum additions:
EnchantedLinkServicegainssignIn/signInWithPhone/signUpOrIn/signUpOrInWithPhoneoverloads takingEnchantedLinkSignInOptions(thesignUpOrInones also take a token andLoginOptions),signUp/signUpWithPhoneoverloads takingEnchantedLinkSignUpOptions, andverify(token, byte[] pkceVerifier). No new enum values.Also:
UserResponse.getTOTP/getSAML/getOAuthwere never populated because Jackson bound them to lowercase names; they now readTOTP/SAML/OAuth(lowercase is still accepted), which affects everyUserResponse, including mgmt user loads.In a Nutshell
POST /v1/auth/enchantedlink/signin/email->EnchantedLinkService.signIn(providerId,templateId,ssoAppId,useRecovery;LoginOptionsgainsssoAppId,pkceChallenge,tenantId)POST /v1/auth/enchantedlink/signin/sms->EnchantedLinkService.signInWithPhone(same as above)POST /v1/auth/enchantedlink/signup-in/email->EnchantedLinkService.signUpOrIn(token,LoginOptions, and the sign-in options above)POST /v1/auth/enchantedlink/signup-in/sms->EnchantedLinkService.signUpOrInWithPhone(same as above)POST /v1/auth/enchantedlink/signup/email->EnchantedLinkService.signUp(providerId,templateId;SignUpOptionsgainslocale,pkceChallenge,templateId,tenantId;UsergainsloginId,recoveryEmail,recoveryPhone)POST /v1/auth/enchantedlink/signup/sms->EnchantedLinkService.signUpWithPhone(same as above)POST /v1/auth/enchantedlink/update/email->EnchantedLinkService.updateUserEmail(UpdateOptionsgainsproviderId,templateId,locale,failOnConflict)POST /v1/auth/enchantedlink/update/phone/sms->EnchantedLinkService.updateUserPhone(same as above)POST /v1/auth/enchantedlink/verify->EnchantedLinkService.verify(pkceVerifier)POST /v1/auth/enchantedlink/pending-session->EnchantedLinkService.getSession(AuthenticationInfoandUserResponsegain the remaining response fields, includingUserFamily, SCIM and OIDC flags)Must
Generated by Descope SDK Agent 🤖🌟