Repository navigation
Conversation
ddelange
force-pushed
the
win-arm64-linux-i686
branch
3 times, most recently
from
October 17, 2026 14:55
1577731 to
08373ce
Compare
Run add_libmagic.sh in MSYS2 like on linux and macos, instead of bundling the MSYS2 file package: current MSYS2 no longer ships mingw-w64-i686-file, its last build crashes (0xC0000409) on any magic_file call, and 5.47 breaks from_buffer ref ahupp#362 Link the UCRT like python does (ucrt64, and -mcrtdll=ucrt on win32), which fixes from_descriptor (Bad file descriptor). Bundle only the DLLs libmagic actually imports (ntldd -R), instead of the flattened package dependency tree.
Replaces the inline smoke test, which moves into the suite as test_from_buffer_hls_mp4 (also guards ahupp#362). On Windows: check out test data without CRLF conversion, and skip what libmagic does not support there (symlinks, non-ANSI paths).
libmagic 5.46 built from source passes the test suite on manylinux2014_i686 and musllinux_1_1_i686.
Built natively on the windows-11-arm runner with the MSYS2 clangarm64 toolchain.
ddelange
force-pushed
the
win-arm64-linux-i686
branch
from
October 17, 2026 15:32
08373ce to
13a5942
Compare
5.48 fixes the from_buffer regression of 5.47 ref ahupp#362 (guarded by test_from_buffer_hls_mp4). 5.48 identifies parquet files (application/vnd.apache.parquet, Apache Parquet file).
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds linux i686 and windows arm64 wheels to ahupp#294, in separate commits so they can be cherry-picked instead of squashed:
add_libmagic.shnow runs in MSYS2 like it does on linux and macos (CIBW_BEFORE_BUILD_WINDOWS), instead of bundling the MSYS2filepackage. That package is a dead end: current MSYS2 no longer shipsmingw-w64-i686-file, its last build crashes (0xC0000409) on anymagic_filecall, and 5.47 breaksfrom_buffer(from_buffer()issue with file-5.47 ahupp/python-magic#362). libmagic now links the UCRT like python does (ucrt64 instead of mingw64, and-mcrtdll=ucrton win32), which fixesfrom_descriptor(Bad file descriptor) in the windows wheels. Only the DLLs libmagic actually imports are bundled (ntldd -R), instead of the hardcoded flattened package dependency tree. The script changes are inert outside MSYS2:--prefix="${MINGW_PREFIX:-/usr/local}"and one DLL copy line.CIBW_TEST_COMMANDrunning pytest against the installed wheel on every platform. The inline smoke test moves into the suite astest_from_buffer_hls_mp4. On Windows, test data is checked out without CRLF conversion (.gitattributes), and the suite skips what libmagic does not support there (symlinks, non-ANSI paths).*Invalid datetime*failure (ahupp@ca4def3) is gone.windows-11-arm(pythonarm64 3.12) with the MSYS2 clangarm64 toolchain.🤖 Generated with Claude Code