You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(#354): read ckan.plugins as a list in FormulaStage.should_skip - #356
FormulaStage.should_skip read ckan.plugins with .split(). CKAN declares that option as a list since 2.10, so tk.config.get("ckan.plugins") returns a list, the AttributeError was swallowed by the broad except Exception, and the stage logged Unable to check ckan.plugins configuration: 'list' object has no attribute 'split' and skipped DRUF formula processing on every job, even with ckanext-scheming enabled.
The stage now reads the option through toolkit.aslist, which accepts both the list and the legacy string form. A regression test covers the list form with scheming, the string form with scheming, and a list without scheming.
Check
Observed result
pytest tests/test_issue_354_plugins_list.py before the fix
2 failed, 1 passed
pytest tests/test_issue_354_plugins_list.py after the fix
The broad except Exception is unchanged. Narrowing it so a real config failure is not reported as "scheming not enabled" is a separate decision; this PR only fixes the cause the except was hiding.
Two pre-existing flake8 findings in formula.py are left alone (unused Optional import, a continuation indent on the scheming_plugins list); they are not on the changed lines.
Observed on CKAN 2.13.0a0 with prefect_enabled = false; the same should_skip runs on the Prefect path.
CKAN declares ckan.plugins as a list option since 2.10, so
tk.config.get("ckan.plugins") returns a list. should_skip called .split()
on it, the AttributeError was caught by the broad except and reported as
"skip", so DRUF formula processing was silently disabled on every job
even with ckanext-scheming enabled.
Read the option through toolkit.aslist, which accepts both the list and
the legacy string form. Regression test covers both forms and the
no-scheming case.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The failing unit and integration checks here die on import prefect (TypeError: Body() got an unexpected keyword argument 'min_items', FastAPI 0.155+ vs Prefect 3.7.8) before any test runs. That is #353, not this change; main fails the same way. #358 pins fastapi<0.155; once it lands, rerunning the checks here should go green.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
✅ No blocking issues noticed
No blocking findings were identified. The required list-valued, legacy string-valued, and scheming-absent plugin configurations are covered by regression tests.
Test suggestions
Scheming is detected in a list-valued ckan.plugins configuration.
Scheming is detected in a legacy string-valued ckan.plugins configuration.
Formula processing is skipped when the plugin list lacks scheming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Fixes #354
Proposed fixes:
FormulaStage.should_skipreadckan.pluginswith.split(). CKAN declares that option as a list since 2.10, sotk.config.get("ckan.plugins")returns a list, theAttributeErrorwas swallowed by the broadexcept Exception, and the stage loggedUnable to check ckan.plugins configuration: 'list' object has no attribute 'split'and skipped DRUF formula processing on every job, even with ckanext-scheming enabled.The stage now reads the option through
toolkit.aslist, which accepts both the list and the legacy string form. A regression test covers the list form with scheming, the string form with scheming, and a list without scheming.pytest tests/test_issue_354_plugins_list.pybefore the fixpytest tests/test_issue_354_plugins_list.pyafter the fixpytest tests --ignore=tests/integration --ignore=tests/js(with--ckan-ini)flake8 --extend-ignore=E501on the test fileexcept Exceptionis unchanged. Narrowing it so a real config failure is not reported as "scheming not enabled" is a separate decision; this PR only fixes the cause the except was hiding.formula.pyare left alone (unusedOptionalimport, a continuation indent on thescheming_pluginslist); they are not on the changed lines.prefect_enabled = false; the sameshould_skipruns on the Prefect path.🤖 Generated with Claude Code