Skip to content

Update default deletion threshold to 0.1% and remove redundant 0.1% per-import rules - #2301

Merged
vish-cs merged 1 commit into
datacommonsorg:masterfrom
ajaits:default-deletion-threshold-cleanup
Oct 25, 2026
Merged

vish-cs merged 1 commit into
datacommonsorg:masterfrom
ajaits:default-deletion-threshold-cleanup

Conversation

@ajaits

@ajaits ajaits commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Updates the default check_deleted_records_percent (DELETED_RECORDS_PERCENT) threshold in tools/import_validation/validation_config.json from 0 (0%) to 0.1 (0.1%), and removes the redundant 0.1% check_deleted_records_percent rule from 67 per-import validation_config*.json files (68 files changed, 4 insertions(+), 533 deletions(-)).

Design & Follow-Up Golden Validations Analysis:

Changes

  1. Default Validation Config (tools/import_validation/validation_config.json):
    • Updated check_deleted_records_percent (DELETED_RECORDS_PERCENT) "threshold" from 0 to 0.1.
  2. Per-Import Validation Config Cleanup (67 Files):
    • Removed the identical check_deleted_records_percent ("threshold": 0.1) rule from 64 multi-rule validation_config*.json files while preserving all other import-specific validation rules (GOLDENS_CHECK, LINT_ERROR_COUNT, MISSING_REFS_COUNT, SQL_VALIDATOR, etc.).
    • Emptied "rules": [] in 3 single-rule validation_config.json files (scripts/us_bts/latch/validation_config.json, statvar_imports/cdc/CDCWonder_NNDSS_Infectious_Weekly/validation_config.json, and statvar_imports/us_nces/nces_employed_college_grads/validation_config.json) so manifest.json references remain valid and inherit the default 0.1% threshold cleanly.
    • Preserved all 15 custom-threshold / disabled validation_config*.json files that override check_deleted_records_percent with non-0.1 thresholds (0.05, 0.2, 0.3, 0.5, 0.6, 1.0, 2.0, 2.5, 6.0) or "enabled": false.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consolidates the validation configuration by removing the redundant check_deleted_records_percent rule from numerous individual dataset configuration files. Instead, the default threshold for the DELETED_RECORDS_PERCENT validator has been updated from 0 to 0.1 in the global tools/import_validation/validation_config.json file. I have no additional feedback to provide.

@ajaits
ajaits requested a review from vish-cs October 24, 2026 19:36
@vish-cs
vish-cs force-pushed the default-deletion-threshold-cleanup branch from d49ecc1 to a294a89 Compare October 25, 2026 03:14
@vish-cs
vish-cs merged commit 7ac40ce into datacommonsorg:master Oct 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants