Repository navigation
Update default deletion threshold to 0.1% and remove redundant 0.1% per-import rules - #2301
Merged
vish-cs merged 1 commit intoOct 25, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request consolidates the validation configuration by removing the redundant check_deleted_records_percent rule from numerous individual dataset configuration files. Instead, the default threshold for the DELETED_RECORDS_PERCENT validator has been updated from 0 to 0.1 in the global tools/import_validation/validation_config.json file. I have no additional feedback to provide.
vish-cs
approved these changes
Oct 25, 2026
vish-cs
force-pushed
the
default-deletion-threshold-cleanup
branch
from
October 25, 2026 03:14
d49ecc1 to
a294a89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the default
check_deleted_records_percent(DELETED_RECORDS_PERCENT) threshold intools/import_validation/validation_config.jsonfrom0(0%) to0.1(0.1%), and removes the redundant0.1%check_deleted_records_percentrule from 67 per-importvalidation_config*.jsonfiles (68 files changed, 4 insertions(+), 533 deletions(-)).Design & Follow-Up Golden Validations Analysis:
Changes
tools/import_validation/validation_config.json):check_deleted_records_percent(DELETED_RECORDS_PERCENT)"threshold"from0to0.1.check_deleted_records_percent("threshold": 0.1) rule from 64 multi-rulevalidation_config*.jsonfiles while preserving all other import-specific validation rules (GOLDENS_CHECK,LINT_ERROR_COUNT,MISSING_REFS_COUNT,SQL_VALIDATOR, etc.)."rules": []in 3 single-rulevalidation_config.jsonfiles (scripts/us_bts/latch/validation_config.json,statvar_imports/cdc/CDCWonder_NNDSS_Infectious_Weekly/validation_config.json, andstatvar_imports/us_nces/nces_employed_college_grads/validation_config.json) somanifest.jsonreferences remain valid and inherit the default0.1%threshold cleanly.validation_config*.jsonfiles that overridecheck_deleted_records_percentwith non-0.1thresholds (0.05,0.2,0.3,0.5,0.6,1.0,2.0,2.5,6.0) or"enabled": false.