Repository navigation
Conversation
|
Implementation for #330 published as c7f0390. Run: schema:2 profile:deep_coder requested:openai/gpt-6.1-sol effort:medium resolved:? All required local executable checks pass: configured suite 2,143 tests (one skipped), Orca fixtures and helper boundary 14 tests, and package validation. The required host campaign remains unverified; this is not merge readiness. The stock CLI blocks planned Orca launch/resume/cancel capabilities whose live bindings have not been verified. Security audit ran: no confirmed changed-surface vulnerability. Live coordinator authentication/capabilities remain unverified. BasedPyright CLI reports 132 baseline errors and no additional error messages on the touched runtime files. No settings were weakened. Verification (agent-reported), tests.version=2. The frozen marker {
"version": 2,
"ran": true,
"passed": false,
"conclusion": "not_verified",
"boundary": "required",
"head_sha": "c7f03906d2b7e76ddf3acb4b691f4ab229e705d6",
"checks": [
{
"id": "configured-test",
"command": "python3 -m unittest discover -s tests",
"executor": "codex",
"profile": "deep_coder",
"context": "project",
"required": true,
"criteria": [],
"level": "test",
"provenance": "project",
"reason": "configured test command",
"head_sha": "c7f03906d2b7e76ddf3acb4b691f4ab229e705d6",
"result": "pass",
"evidence": [
{
"exit_code": 0,
"executed": 2143
}
],
"cause": "",
"attempts": [],
"history": [
{
"head_sha": "7c0f28b5384b37a43daa6ef5a793f90a18006007",
"result": "fail",
"evidence": [
{
"exit_code": 1,
"executed": 2137,
"dirty_worktree": true
}
],
"cause": "defect",
"attempts": [
{
"note": "Uncommitted implementation changed during this first run; fixed missing test registrations before final commit. This history does not verify the baseline commit."
}
]
}
]
},
{
"id": "orca-parity",
"command": "python3 -m unittest discover -s tests -p test_orca_plan.py",
"executor": "codex",
"profile": "deep_coder",
"context": "project",
"required": true,
"criteria": [
"AC-1",
"AC-2",
"AC-3",
"AC-4",
"AC-5",
"AC-6",
"AC-7",
"AC-8"
],
"level": "boundary",
"provenance": "agent",
"reason": "Orca parity fixtures and installed-helper subprocess boundary",
"head_sha": "c7f03906d2b7e76ddf3acb4b691f4ab229e705d6",
"result": "pass",
"evidence": [
{
"exit_code": 0,
"executed": 14
}
],
"cause": "",
"attempts": []
},
{
"id": "package-validation",
"command": "python3 scripts/validate-package.py",
"executor": "codex",
"profile": "deep_coder",
"context": "project",
"required": true,
"criteria": [
"AC-2",
"AC-4",
"AC-6"
],
"level": "static",
"provenance": "project",
"reason": "runtime manifests and skill/package validation",
"head_sha": "c7f03906d2b7e76ddf3acb4b691f4ab229e705d6",
"result": "pass",
"evidence": [
{
"exit_code": 0,
"executed": null
}
],
"cause": "",
"attempts": []
},
{
"id": "orca-live",
"command": "manual:orca-live",
"executor": "host",
"profile": "deep_coder",
"context": "host-orca",
"required": true,
"criteria": [
"AC-1",
"AC-2",
"AC-3",
"AC-4",
"AC-5",
"AC-7",
"AC-8"
],
"level": "boundary",
"provenance": "project",
"reason": "Required exact-HEAD controlled host Orca campaign; non-executable manual marker documented in docs/orca-execution-plan.md",
"head_sha": "c7f03906d2b7e76ddf3acb4b691f4ab229e705d6",
"result": "unverified",
"evidence": [],
"cause": "Per issue decision 10, Orca is not run in the implementer sandbox. No exact-HEAD host campaign result or observed installed version was supplied.",
"attempts": []
}
]
}Checks of the pushed head (single read, parallel CI policy): {
"head_sha": "c7f03906d2b7e76ddf3acb4b691f4ab229e705d6",
"passed": 0,
"failed": 0,
"pending": 5,
"items": [
{
"name": "Skills, manifests, and Bash installer",
"state": "pending"
},
{
"name": "Windows test shard (windows-1)",
"state": "pending"
},
{
"name": "Windows test shard (windows-2)",
"state": "pending"
},
{
"name": "Windows test shard (windows-3)",
"state": "pending"
},
{
"name": "Windows test shard (windows-4)",
"state": "pending"
}
]
} |
Initial review — PR #384 (work item #330)[CCR-20261102-001] · senior_reviewer · anthropic/claude-opus-5-5→? · high · schema:2Verdict: ScopeI read the full accumulated diff,
The documentation rule in Sharing the plan logic is behaviour-preserving for the native driver:
Findings[REV-001] · medium · open · - · blocks:no — Native
|
| Check | Command | Required | Criteria | Result |
|---|---|---|---|---|
configured-test |
python3 -m unittest discover -s tests |
yes | AC-1, AC-2, AC-3, AC-4, AC-5, AC-6, AC-8 | pass: exit 0, Ran 2143 tests in 217.344s, OK (skipped=1) |
validate-package |
python3 scripts/validate-package.py |
yes | — | pass: exit 0, VALID: 16 skills (7 cycle, 9 supporting), shared sections in sync, cross-agent manifests aligned |
orca-plan-focused |
python3 -m unittest discover -s tests -p test_orca_plan.py -v |
no | AC-1, AC-2, AC-3, AC-4, AC-5, AC-6, AC-8 | pass: exit 0, 14 tests OK |
unittest-default |
python3 -m unittest |
no | — | inconclusive: exit 0 but Ran 0 tests. Default discovery from the repository root finds no tests, so this configured command proves nothing. |
orca-live |
host-side Orca campaign on the exact SHA (issue decision 10) | yes | AC-7 | unverified: not runnable in this review stage |
How each acceptance criterion is covered:
- AC-1 (equivalent obligations):
plan_serviceis shared, andtest_equivalent_inputs_and_task_specs_in_every_modechecks every mode. - AC-2 (profile and revision travel with the delegation):
delegation_specandOrcaDispatchContext.task_spec(). - AC-3 (a launch is not a result):
IN_PROGRESS+result_pending, andreconcile_outcomerejectsworker_done. Native-route reachability is limited; see REV-001. - AC-4 (review workspace and publication):
test_launch_is_only_pending_and_review_workspace_is_preserved, and publication permissions are kept in the spec. - AC-5 (HEAD changes and partial results): the shared
invalidate_head, plus frozen-check recovery tests. - AC-6 (documented modes):
docs/orca-execution-plan.mdcovers the five modes and their terminal obligations, and a test checks them. - AC-7 (Orca version and limitations recorded): open. No observed Orca version or verified limitation is recorded yet, and 1.4.209 is planning context only.
- AC-8 (conditional rereview):
test_rereview_is_conditional_in_every_mode_and_retains_blocks, plus the skill update.
The behaviour of REV-001 was confirmed by reading the code: select_plan_stage → save_plan → persist_plan runs immediately before run() builds the context. I did not reproduce it with a non-echo reader.
CI (parallel policy, read once, not waited on)
Skills, manifests, and Bash installer: passWindows test shard (windows-2): passWindows test shard (windows-1): pendingWindows test shard (windows-3): pendingWindows test shard (windows-4): pending
The new test_orca_plan module is registered in the windows-1 and windows-3 shard lists.
Unverified items
orca-liveand AC-7 need the host Orca campaign on this exact SHA. The implementer and reviewer sandboxes do not run Orca.python3 -m unittest(default discovery) runs 0 tests, so it is not evidence.
Residual risks
- The native Orca route stays launch-blocked (REV-001), and resume and cancel stay
BLOCKEDuntil a coordinator binding exists. orca_plan.py initializekeeps the deterministic dry-runplan_id(run:<repo>#<task>). The native driver usesplan-<cycle_id>. Plan identity therefore does not distinguish Orca cycles of the same work item and PR scope;--cycleis recorded separately.- BasedPyright baseline errors are pre-existing (implementer report); not rechecked here.
Use the shared execution-plan operations across native and supervised Orca paths, and block planned Orca launches unless the existing Task's plan can be confirmed. Launch completion remains transport evidence; it cannot advance the functional cycle.
Refs #330. The issue remains open until the required exact-HEAD host Orca campaign passes.
Run: schema:2 profile:deep_coder requested:openai/gpt-6.1-sol effort:medium resolved:?
Diagnosis
Feature request; decision
implement. The nativePlanRuntimeowned persistence and HEAD invalidation,OrcaDispatchContexthad no plan, and the native route did not build that context. This confirms the issue's mechanism: transport-specific interpretation could diverge from the shared obligations. Defect reproduction was not applicable; fixtures exercise the new behavior. The invariant is that every transport consumes the same effective plan, canonical receipt, policy gates and HEAD-bound evidence rules, while Orca retains Run/Task/worker ownership.Related work was searched by execution-plan/Orca terms and the implicated shared symbols: #329 is closed; merged #361, #362, #366 and #371 establish the shared contracts. #382 tracks host-attested evidence separately and explicitly is not a strict dependency of #330.
Work units
scripts/plan_service.py,scripts/orca_plan.py, native driver/adapter modules, runtime/test manifests,skills/cc-orca-orchestrator/SKILL.md,docs/execution-plan.md,docs/orca-execution-plan.mdtests/test_orca_plan.py; existing driver, installation, fast-path and workflow suitesBehaviour and documentation
CycleHistoryStore.save_plan, HEAD invalidation and security requirements. Frozen check identities/history survive recovery; stale results cannot satisfy another HEAD.IN_PROGRESSwithresult_pendingevidence. Missing capabilities reportBLOCKEDwithout inventing a coordinator or relaunching.The new behaviour was not already documented.
docs/orca-execution-plan.mdnow owns the helper/CLI flow, all five mode examples and terminal obligations, unsupported interfaces and required live evidence;docs/execution-plan.mdlinks it. Test registration covers Windows shards and documentation fast-path dependencies.Verification limits
Agent-reported local verification on
c7f03906d2b7e76ddf3acb4b691f4ab229e705d6:python3 -m unittest discover -s tests: exit 0, 2,143 tests, one skipped (270.107 seconds).python3 -m unittest discover -s tests -p test_orca_plan.py: exit 0, 14 tests, including the helper subprocess boundary.python3 scripts/validate-package.py: exit 0; 16 skills and runtime manifests validate.git diff --check: exit 0.The first full run was on an uncommitted worktree and failed (2,137 tests, 13 failures and one error). It exposed missing Windows shard and fast-path registrations, which were fixed before this commit. Its remaining driver case passed on a focused rerun and in the final full run. That earlier dirty-tree run is retained as history, not evidence for this committed HEAD.
The stock native CLI has no verified live Task-spec reader, authoritative-outcome or cancellation binding. It deliberately blocks these capabilities. API fixtures supply an existing coordinator's capability; no undocumented Orca CLI option or endpoint is assumed. The required manual check
orca-liveremains unverified until a host campaign on this exact commit records the actual installed version, commands, environment, Task contents, identities, plan receipt and authoritative functional outcomes for launch/resume/partial/stale/cancel cases. Orca 1.4.209 is planning context only, not observed evidence. No Orca CLI was run in the implementer sandbox.Local fixtures use temporary repositories, fake process boundaries and explicit test identities; they do not require provider credentials or user-global Git identity. Prepared dependencies were inspected and are not counted as tests. BasedPyright reports 132 existing errors on both the base snapshot and the touched final runtime files, with no additional error messages; the raw type check still exits 1. No type-check settings were changed.
Security audit ran over the accumulated change: plan/Task/result identity boundaries, persisted commands, publication gates, workspace isolation and helper input handling. No confirmed vulnerability was found. Live coordinator authentication/capabilities were not exercised; the required host campaign remains the verification boundary. This is not review approval or merge readiness.