Skip to content

Cherry-pick from oracle-structsupport - #682

Open
vanshikaagupta22 wants to merge 1 commit into
data-integrations:release/1.11from
cloudsufi:oracle-structsupport-cherrypick
Open

vanshikaagupta22 wants to merge 1 commit into
data-integrations:release/1.11from
cloudsufi:oracle-structsupport-cherrypick

Conversation

@vanshikaagupta22

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Oracle STRUCT (User-Defined Types) in the Oracle database plugin, enabling the mapping of structured database types to CDAP StructuredRecord schemas and records. It implements schema reading, attribute mapping, and data conversion for nested structures and Oracle-specific types, along with comprehensive unit tests. The review feedback identifies several critical robustness and performance issues, including potential NullPointerException risks when retrieving connections from result set statements or loading classes via the bootstrap classloader, SQL query ambiguity when extracting type owners, missing validation for null type owners, and performance bottlenecks from repeated reflection calls.

Comment thread database-commons/src/main/java/io/cdap/plugin/db/DBRecord.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants