Repository navigation
refactor: merge duplicated helpers - #421
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Merges copies of the same helper into one, with no behavior change. Copies that differ in timeout or output stay separate.
GhosttyTerminalSupport.swift. The twoWorkspaceinitializers share their Bonsplit setup.TypingProfiler's run-loop label, theAgentTaskStatemapping in telemetry, and the review error mapping each exist once.makeTemporaryDirectory,waitForConditionand git runners collapse into one each._find_cli_binaryand identical local wait helpers move intov2_support.py.Review order
Sources/Workspace.swift(init extraction)Sources/GhosttyTerminalSupport.swift,TerminalSurface.swift,CLIInstaller.swift(shell quoting)tests_v2/v2_support.py, then the callersTest plan