Skip to content

refactor: remove dead code, unused scripts and v1-only tests - #420

Merged
arzafran merged 2 commits into
mainfrom
chore/remove-dead-code
Oct 9, 2026
Merged

arzafran merged 2 commits into
mainfrom
chore/remove-dead-code

Conversation

@arzafran

@arzafran arzafran commented Oct 9, 2026

Copy link
Copy Markdown
Member

What this does

Deletes code, scripts and tests that nothing runs. The one user-visible change is that the old programa codex install-hooks and uninstall-hooks aliases are gone; install-integration and uninstall-integration do the same thing and are what the docs already point to.

What goes

  • The CLI's fallback for servers without system.tree. The app and CLI ship together, so it never ran.
  • Unused functions: TabManager.closeSurface, NotificationSoundSettings.isSilent, the app-icon observer's stopObserving, the debug flash helpers in Panel.swift, MCP stringArray.
  • The draw-stats chain, which always reported zero. The debug render_stats payload loses drawCount and lastDrawTime.
  • Test-only helpers in TerminalController.swift and their tests.
  • Two Rust FFI exports the Windows app never calls (scroll_to_bottom, selection_clear) and their header and ABI doc entries.
  • scripts/launch-tagged-automation.sh, scripts/icon-gen/, tests_v2/test_v1_panel_creation_preserves_focus.py (v1 commands only, never in CI) and tests_v2/test_visual_screenshots.py (manual screenshot tool).

Review order

  1. CLI/CLI+Tree.swift (biggest Swift cut)
  2. CLI/HookInstallationCoordinator.swift plus tests/test_cli_codex_hook_trust.py (alias removal; the test now uses the current names)
  3. Everything else is straight deletion.

Test plan

  • CI passes, including test_cli_codex_hook_trust.py
  • programa codex install-integration still installs the hooks

@arzafran
arzafran merged commit cb1ab4e into main Oct 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant